fog/fog-azure-rm

View on GitHub
lib/fog/azurerm/requests/network/create_or_update_public_ip.rb

Summary

Maintainability
A
2 hrs
Test Coverage
F
31%

Method create_or_update_public_ip has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def create_or_update_public_ip(resource_group, name, location, public_ip_allocation_method, idle_timeout_in_minutes, domain_name_label, tags)
Severity: Major
Found in lib/fog/azurerm/requests/network/create_or_update_public_ip.rb - About 50 mins to fix

    Method get_public_ip_object has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def get_public_ip_object(name, location, public_ip_allocation_method, idle_timeout_in_minutes, domain_name_label, tags)
    Severity: Minor
    Found in lib/fog/azurerm/requests/network/create_or_update_public_ip.rb - About 45 mins to fix

      Method get_public_ip_object has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def get_public_ip_object(name, location, public_ip_allocation_method, idle_timeout_in_minutes, domain_name_label, tags)
                public_ip = Azure::ARM::Network::Models::PublicIPAddress.new
                public_ip.name = name
                public_ip.location = location
                public_ip.public_ipallocation_method = public_ip_allocation_method unless public_ip_allocation_method.nil?
      Severity: Minor
      Found in lib/fog/azurerm/requests/network/create_or_update_public_ip.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status