Sign upLogin

fog/fog-azure-rm

View on GitHub
Star
lib/fog/azurerm/requests/network/get_load_balancer.rb

Summary

Maintainability
B
5 hrs
Test Coverage
F
43%

Method get_load_balancer has 144 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def get_load_balancer(*)
          response = '{
            "name":"mylb1",
            "id":"/subscriptions/{guid}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/loadBalancers/mylb1",
            "location":"North US",
Severity: Major
Found in lib/fog/azurerm/requests/network/get_load_balancer.rb - About 5 hrs to fix

    Prefer JSON.parse over JSON.load.
    Open

              @network_client.deserialize(load_balancer_mapper, JSON.load(response), 'result.body')
    Severity: Minor
    Found in lib/fog/azurerm/requests/network/get_load_balancer.rb by rubocop

    This cop checks for the use of JSON class methods which have potential security issues.

    Autocorrect is disabled by default because it's potentially dangerous. If using a stream, like JSON.load(open('file')), it will need to call #read manually, like JSON.parse(open('file').read). If reading single values (rather than proper JSON objects), like JSON.load('false'), it will need to pass the quirks_mode: true option, like JSON.parse('false', quirks_mode: true). Other similar issues may apply.

    Example:

    # always offense
JSON.load("{}")
JSON.restore("{}")

# no offense
JSON.parse("{}")

    There are no issues that match your filters.

    Category
    Status