lib/fog/azurerm/requests/resources/delete_resource_tag.rb
Method delete_resource_tag has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def delete_resource_tag(resource_id, tag_name, tag_value, api_version = API_VERSION)
split_resource = resource_id.split('/') unless resource_id.nil?
if split_resource.count != 9
raise 'Invalid Resource Id'
end- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. Open
Open
if split_resource.count != 9- Read upRead up
- Exclude checks
Checks for if and unless statements that would fit on one line
if written as a modifier if/unless. The maximum line length is
configured in the Metrics/LineLength cop.
Example:
# bad
if condition
do_stuff(bar)
end
unless qux.empty?
Foo.do_something
end
# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?Carriage return character detected. Open
Open
module Fog
module Resources- Exclude checks
Unnecessary spacing detected. Open
Open
rescue MsRestAzure::AzureOperationError => e- Read upRead up
- Exclude checks
This cop checks for extra/unnecessary whitespace.
Example:
# good if AllowForAlignment is true
name = "RuboCop"
# Some comment and an empty line
website += "/bbatsov/rubocop" unless cond
puts "rubocop" if debug
# bad for any configuration
set_app("RuboCop")
website = "https://github.com/bbatsov/rubocop"