lib/fog/azurerm/requests/resources/list_tagged_resources.rb
Method list_tagged_resources has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
def list_tagged_resources(tag_name, tag_value = nil)
msg = "Listing Resources with tagname: #{tag_name}"
Fog::Logger.debug msg
unless tag_name.nil?
query_filter = "tagname eq '#{tag_name}' "- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Use a guard clause instead of wrapping the code inside a conditional expression. Open
Open
unless tag_name.nil?- Read upRead up
- Exclude checks
Use a guard clause instead of wrapping the code inside a conditional expression
Example:
# bad
def test
if something
work
end
end
# good
def test
return unless something
work
end
# also good
def test
work if something
end
# bad
if something
raise 'exception'
else
ok
end
# good
raise 'exception' if something
okCarriage return character detected. Open
Open
module Fog
module Resources- Exclude checks