Sign upLogin

fog/fog-azure-rm

View on GitHub
Star
lib/fog/azurerm/requests/storage/create_disk.rb

Summary

Maintainability
A
1 hr
Test Coverage
F
25%

Method create_disk has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def create_disk(disk_name, disk_size_in_gb, options = {})
          msg = "Creating disk(#{disk_name}, #{disk_size_in_gb}). options: #{options}"
          Fog::Logger.debug msg

          raise ArgumentError, "disk_size_in_gb #{disk_size_in_gb} must be an integer" unless disk_size_in_gb.is_a?(Integer)
Severity: Minor
Found in lib/fog/azurerm/requests/storage/create_disk.rb - About 1 hr to fix

    Method create_disk has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def create_disk(disk_name, disk_size_in_gb, options = {})
          msg = "Creating disk(#{disk_name}, #{disk_size_in_gb}). options: #{options}"
          Fog::Logger.debug msg

          raise ArgumentError, "disk_size_in_gb #{disk_size_in_gb} must be an integer" unless disk_size_in_gb.is_a?(Integer)
    Severity: Minor
    Found in lib/fog/azurerm/requests/storage/create_disk.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid rescuing without specifying an error class.
    Open

              rescue
    Severity: Minor
    Found in lib/fog/azurerm/requests/storage/create_disk.rb by rubocop

    This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

    Example: EnforcedStyle: implicit

    # `implicit` will enforce using `rescue` instead of
# `rescue StandardError`.

# bad
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

    Example: EnforcedStyle: explicit (default)

    # `explicit` will enforce using `rescue StandardError`
# instead of `rescue`.

# bad
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

    Avoid rescuing without specifying an error class.
    Open

                rescue => ex
    Severity: Minor
    Found in lib/fog/azurerm/requests/storage/create_disk.rb by rubocop

    This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

    Example: EnforcedStyle: implicit

    # `implicit` will enforce using `rescue` instead of
# `rescue StandardError`.

# bad
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

    Example: EnforcedStyle: explicit (default)

    # `explicit` will enforce using `rescue StandardError`
# instead of `rescue`.

# bad
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

    There are no issues that match your filters.

    Category
    Status