Sign upLogin

fog/fog-azure-rm

View on GitHub
Star
lib/fog/azurerm/requests/storage/wait_blob_copy_operation_to_finish.rb

Summary

Maintainability
B
4 hrs
Test Coverage
F
22%

Method wait_blob_copy_operation_to_finish has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

        def wait_blob_copy_operation_to_finish(container_name, blob_name, copy_id, copy_status, timeout = nil)
          begin
            start_time = Time.new
            while copy_status == COPY_STATUS[:PENDING]
              blob = get_blob_properties(container_name, blob_name)
Severity: Minor
Found in lib/fog/azurerm/requests/storage/wait_blob_copy_operation_to_finish.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method wait_blob_copy_operation_to_finish has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def wait_blob_copy_operation_to_finish(container_name, blob_name, copy_id, copy_status, timeout = nil)
          begin
            start_time = Time.new
            while copy_status == COPY_STATUS[:PENDING]
              blob = get_blob_properties(container_name, blob_name)
Severity: Minor
Found in lib/fog/azurerm/requests/storage/wait_blob_copy_operation_to_finish.rb - About 1 hr to fix

    Method wait_blob_copy_operation_to_finish has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def wait_blob_copy_operation_to_finish(container_name, blob_name, copy_id, copy_status, timeout = nil)
    Severity: Minor
    Found in lib/fog/azurerm/requests/storage/wait_blob_copy_operation_to_finish.rb - About 35 mins to fix

      Avoid rescuing without specifying an error class.
      Open

                  rescue => ex
      Severity: Minor
      Found in lib/fog/azurerm/requests/storage/wait_blob_copy_operation_to_finish.rb by rubocop

      This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

      Example: EnforcedStyle: implicit

      # `implicit` will enforce using `rescue` instead of
# `rescue StandardError`.

# bad
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

      Example: EnforcedStyle: explicit (default)

      # `explicit` will enforce using `rescue StandardError`
# instead of `rescue`.

# bad
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

      Avoid rescuing without specifying an error class.
      Open

                rescue
      Severity: Minor
      Found in lib/fog/azurerm/requests/storage/wait_blob_copy_operation_to_finish.rb by rubocop

      This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

      Example: EnforcedStyle: implicit

      # `implicit` will enforce using `rescue` instead of
# `rescue StandardError`.

# bad
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

      Example: EnforcedStyle: explicit (default)

      # `explicit` will enforce using `rescue StandardError`
# instead of `rescue`.

# bad
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

      There are no issues that match your filters.

      Category
      Status