fog/fog-ecloud

View on GitHub
lib/fog/compute/ecloud/requests/virtual_machine_import.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method virtual_machine_import has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def virtual_machine_import(template_uri, options)
          options         = validate_import_server_options(template_uri, options)

          compute_pool_id = options[:uri].match(/computePools\/(\d+)/)[1].to_i
          compute_pool    = self.data[:compute_pools][compute_pool_id].dup
Severity: Major
Found in lib/fog/compute/ecloud/requests/virtual_machine_import.rb - About 4 hrs to fix

    Method build_request_body_import has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def build_request_body_import(options)
              xml = Builder::XmlMarkup.new
              xml.ImportVirtualMachine(:name => options[:name]) do
                xml.ProcessorCount options[:cpus]
                xml.Memory do
    Severity: Minor
    Found in lib/fog/compute/ecloud/requests/virtual_machine_import.rb - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  :HardwareConfiguration => {
                    :href => "/cloudapi/ecloud/virtualmachines/#{server_id}/hardwareconfiguration",
                    :type => "application/vnd.tmrk.cloud.virtualMachineHardware",
                    :Links => {
                      :Link => {
      Severity: Major
      Found in lib/fog/compute/ecloud/requests/virtual_machine_import.rb and 1 other location - About 1 hr to fix
      lib/fog/compute/ecloud/requests/virtual_machine_create_from_template.rb on lines 150..177

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                row = {
                  :id => row_id,
                  :name => options[:row],
                  :href => "/cloudapi/ecloud/layoutrows/#{row_id}",
                  :type => "application/vnd.tmrk.cloud.layoutRow",
      Severity: Minor
      Found in lib/fog/compute/ecloud/requests/virtual_machine_import.rb and 1 other location - About 35 mins to fix
      lib/fog/compute/ecloud/requests/virtual_machine_create_from_template.rb on lines 190..205

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                group = {
                  :id => group_id,
                  :name => options[:group],
                  :href => "/cloudapi/ecloud/layoutgroups/#{group_id}",
                  :type => "application/vnd.tmrk.cloud.layoutGroup",
      Severity: Minor
      Found in lib/fog/compute/ecloud/requests/virtual_machine_import.rb and 1 other location - About 35 mins to fix
      lib/fog/compute/ecloud/requests/virtual_machine_create_from_template.rb on lines 208..224

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                nics            = networks.each_with_index.map do |network, i|
                  {
                    :UnitNumber => i.to_s,
                    :Name       => "Network adapter #{i}",
                    :MacAddress => Fog::Ecloud.mac_address,
      Severity: Minor
      Found in lib/fog/compute/ecloud/requests/virtual_machine_import.rb and 1 other location - About 15 mins to fix
      lib/fog/compute/ecloud/requests/virtual_machine_create_from_template.rb on lines 126..131

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status