Sign upLogin

fog/fog-openstack

View on GitHub
Star

Showing 616 of 616 total issues

Method list_resources has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def list_resources(_type = "generic", _options = {})
          response = Excon::Response.new
          response.status = 200
          response.body = [
              {
Severity: Minor
Found in lib/fog/openstack/metric/requests/list_resources.rb - About 1 hr to fix

    Method build_credentials has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

              def build_credentials(auth)
            if auth[:openstack_project_id] || auth[:openstack_project_name]
              # project scoped
              @project = Fog::OpenStack::Auth::ProjectScope.new(
                auth[:openstack_project_id],
    Severity: Minor
    Found in lib/fog/openstack/auth/token/v3.rb - About 1 hr to fix

      Method list_bay_models has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def list_bay_models
          response = Excon::Response.new
          response.status = 200
          response.body = {
            "baymodels" => [
      Severity: Minor
      Found in lib/fog/openstack/container_infra/requests/list_bay_models.rb - About 1 hr to fix

        Method get_file_contents has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

                def get_file_contents(from_data, base_url)
          Fog::Logger.debug("Processing #{from_data} with base_url #{base_url}")

          # Recursively traverse the tree
          #   if recurse_data is Array or Hash
        Severity: Minor
        Found in lib/fog/openstack/orchestration/util/recursive_hot_file_loader.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method list_zones_detailed has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def list_zones_detailed(_options = {})
          Excon::Response.new(
            :body   => {
              "availabilityZoneInfo" => [
                {
        Severity: Minor
        Found in lib/fog/openstack/compute/requests/list_zones_detailed.rb - About 1 hr to fix

          Method list_services has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  def list_services(_parameters = nil)
          response = Excon::Response.new
          response.status = 200
          response.body = {
            "services" => [{
          Severity: Minor
          Found in lib/fog/openstack/compute/requests/list_services.rb - About 1 hr to fix

            Method get_hypervisor has 44 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    def get_hypervisor(hypervisor_id)
          response = Excon::Response.new
          response.status = 200
          response.body = {
            "hypervisor" => {
            Severity: Minor
            Found in lib/fog/openstack/compute/requests/get_hypervisor.rb - About 1 hr to fix

              Method update_snapshot has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

                      def update_snapshot(snapshot_id, options = {})
          unless snapshot_id
            raise ArgumentError, 'snapshot_id is required'
          end
          response = Excon::Response.new
              Severity: Minor
              Found in lib/fog/openstack/volume/requests/update_snapshot.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method update_stack has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

                      def update_stack(arg1, arg2 = nil, arg3 = nil)
          if arg1.kind_of?(Stack)
            # Normal use, update_stack(stack, options = {})
            stack = arg1
            stack_name = stack.stack_name
              Severity: Minor
              Found in lib/fog/openstack/orchestration/requests/update_stack.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                module OpenStack
    class SharedFileSystem
      class Real
        def update_security_service(id, options = {})
          request(
              Severity: Major
              Found in lib/fog/openstack/shared_file_system/requests/update_security_service.rb and 2 other locations - About 1 hr to fix
              lib/fog/openstack/shared_file_system/requests/update_share_network.rb on lines 2..26
              lib/fog/openstack/shared_file_system/requests/update_snapshot.rb on lines 2..26

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 70.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                module OpenStack
    class SharedFileSystem
      class Real
        def update_share_network(id, options = {})
          request(
              Severity: Major
              Found in lib/fog/openstack/shared_file_system/requests/update_share_network.rb and 2 other locations - About 1 hr to fix
              lib/fog/openstack/shared_file_system/requests/update_security_service.rb on lines 2..26
              lib/fog/openstack/shared_file_system/requests/update_snapshot.rb on lines 2..26

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 70.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                module OpenStack
    class SharedFileSystem
      class Real
        def update_snapshot(id, options = {})
          request(
              Severity: Major
              Found in lib/fog/openstack/shared_file_system/requests/update_snapshot.rb and 2 other locations - About 1 hr to fix
              lib/fog/openstack/shared_file_system/requests/update_security_service.rb on lines 2..26
              lib/fog/openstack/shared_file_system/requests/update_share_network.rb on lines 2..26

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 70.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method get_metric has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      def get_metric(_metric_id)
          response = Excon::Response.new
          response.status = 200
          response.body = {
              "archive_policy" => {
              Severity: Minor
              Found in lib/fog/openstack/metric/requests/get_metric.rb - About 1 hr to fix

                Method list_all_addresses has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        def list_all_addresses(_options = {})
          response = Excon::Response.new
          response.status = 200
          response.headers = {
            "X-Compute-Request-Id" => "req-d4a21158-a86c-44a6-983a-e25645907f26",
                Severity: Minor
                Found in lib/fog/openstack/compute/requests/list_all_addresses.rb - About 1 hr to fix

                  Method auth_response_v2 has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  def auth_response_v2(type, name)
  {
    'access' => {
      'token'          => {
        'issued_at' => '2017-12-05T10:44:31.454741Z',
                  Severity: Minor
                  Found in unit/auth_helper.rb - About 1 hr to fix

                    Method initialize has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                              def initialize(options = {})
            @openstack_username = options[:openstack_username] || 'admin'
            @openstack_tenant = options[:openstack_tenant] || 'admin'
            @openstack_auth_uri = URI.parse(options[:openstack_auth_url])
            @openstack_management_url = @openstack_auth_uri.to_s
                    Severity: Minor
                    Found in lib/fog/openstack/identity/v2.rb - About 1 hr to fix

                      Method get_host_details has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              def get_host_details(_host)
          response = Excon::Response.new
          response.status = 200
          response.body = {"host" => [
            {"resource" => {
                      Severity: Minor
                      Found in lib/fog/openstack/compute/requests/get_host_details.rb - About 1 hr to fix

                        Method list_plans has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                def list_plans(_options = {})
          response = Excon::Response.new
          response.status = [200, 204][rand(2)]
          response.body = [
            {
                        Severity: Minor
                        Found in lib/fog/openstack/planning/requests/list_plans.rb - About 1 hr to fix

                          Method request has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                          Open

                                def request(params, parse_json = true)
        retried = false
        begin
          authenticate! if @expires && (@expires - Time.now.utc).to_i < 60
                          Severity: Minor
                          Found in lib/fog/openstack/core.rb - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Open

                          module Fog
  module OpenStack
    class Volume
      class V2
        class Real
                          Severity: Major
                          Found in lib/fog/openstack/volume/v2/requests/create_snapshot.rb and 2 other locations - About 1 hr to fix
                          lib/fog/openstack/volume/v1/requests/create_snapshot.rb on lines 3..39
                          lib/fog/openstack/volume/v3/requests/create_snapshot.rb on lines 3..39

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 65.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language