Sign upLogin

fog/fog-openstack

View on GitHub
Star
lib/fog/openstack/compute/models/server.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Server has 47 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Server < Fog::Compute::Server
        identity :id
        attribute :instance_name, :aliases => 'OS-EXT-SRV-ATTR:instance_name'

        attribute :addresses
Severity: Minor
Found in lib/fog/openstack/compute/models/server.rb - About 6 hrs to fix

    File server.rb has 323 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'fog/compute/models/server'
require 'fog/openstack/compute/models/metadata'

module Fog
  module OpenStack
    Severity: Minor
    Found in lib/fog/openstack/compute/models/server.rb - About 3 hrs to fix

      Method floating_ip_addresses has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

              def floating_ip_addresses
          all_floating = if addresses
                           flattened_values = addresses.values.flatten
                           flattened_values.select { |d| d["OS-EXT-IPS:type"] == "floating" }.collect { |a| a["addr"] }
                         else
      Severity: Minor
      Found in lib/fog/openstack/compute/models/server.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method rebuild has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def rebuild(image_ref, name, admin_pass = nil, metadata = nil, personality = nil)
      Severity: Minor
      Found in lib/fog/openstack/compute/models/server.rb - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status