Sign upLogin

fog/fog-profitbricks

View on GitHub
Star

Showing 140 of 140 total issues

Method data has 1040 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def self.data
          dc1_id   = Fog::UUID.uuid
          dc2_id   = Fog::UUID.uuid
          serv1_id = Fog::UUID.uuid
          vol1_id  = Fog::UUID.uuid
Severity: Major
Found in lib/fog/profitbricks/compute.rb - About 5 days to fix

    File compute.rb has 1246 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Fog
  module Compute
    class ProfitBricks < Fog::Service
      API_VERSION = 'v4'.freeze
    Severity: Major
    Found in lib/fog/profitbricks/compute.rb - About 3 days to fix

      Method create_server has 123 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def create_server(datacenter_id, properties = {}, entities = {})
          if properties[:cores] == nil
            raise Excon::Error::HTTPStatus, "Attribute 'cores' is required"
          end
      Severity: Major
      Found in lib/fog/profitbricks/requests/compute/create_server.rb - About 4 hrs to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    item = {}
            item[:name]           = firewall_rule[:name] if firewall_rule.key?(:name)
            item[:protocol]       = firewall_rule[:protocol] if firewall_rule.key?(:protocol)
            item[:sourceMac]      = firewall_rule[:source_mac] if firewall_rule.key?(:source_mac)
            item[:sourceIp]       = firewall_rule[:source_ip] if firewall_rule.key?(:source_ip)
        Severity: Major
        Found in lib/fog/profitbricks/models/compute/server.rb and 1 other location - About 2 hrs to fix
        lib/fog/profitbricks/models/compute/nic.rb on lines 99..109

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    item = {}
            item[:name]           = firewall_rule[:name] if firewall_rule.key?(:name)
            item[:protocol]       = firewall_rule[:protocol] if firewall_rule.key?(:protocol)
            item[:sourceMac]      = firewall_rule[:source_mac] if firewall_rule.key?(:source_mac)
            item[:sourceIp]       = firewall_rule[:source_ip] if firewall_rule.key?(:source_ip)
        Severity: Major
        Found in lib/fog/profitbricks/models/compute/nic.rb and 1 other location - About 2 hrs to fix
        lib/fog/profitbricks/models/compute/server.rb on lines 247..257

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method create_datacenter has 66 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def create_datacenter(options, entities={})
          dc = {
            :properties => options,
            :entities => entities
          }
        Severity: Major
        Found in lib/fog/profitbricks/requests/compute/create_datacenter.rb - About 2 hrs to fix

          Method get_firewall_rules has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

                  def get_firewall_rules(firewall_rules)
          items = []
          for firewall_rule in firewall_rules do
            item = {}
            item[:name]           = firewall_rule[:name] if firewall_rule.key?(:name)
          Severity: Minor
          Found in lib/fog/profitbricks/models/compute/server.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  def update
          requires :id

          options = {}
          options[:name]                = name if name
          Severity: Major
          Found in lib/fog/profitbricks/models/compute/snapshot.rb and 1 other location - About 2 hrs to fix
          lib/fog/profitbricks/models/compute/image.rb on lines 40..60

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 94.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  def update
          requires :id

          options = {}
          options[:name]                 = name if name
          Severity: Major
          Found in lib/fog/profitbricks/models/compute/image.rb and 1 other location - About 2 hrs to fix
          lib/fog/profitbricks/models/compute/snapshot.rb on lines 44..64

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 94.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method get_firewall_rules has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
          Open

                  def get_firewall_rules(firewall_rules)
          items = []
          firewall_rules.each do |firewall_rule|
            item = {}
            item[:name]           = firewall_rule[:name] if firewall_rule.key?(:name)
          Severity: Minor
          Found in lib/fog/profitbricks/models/compute/nic.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Class Server has 22 methods (exceeds 20 allowed). Consider refactoring.
          Open

                class Server < Fog::Models::ProfitBricks::Base
        include Fog::Helpers::ProfitBricks::DataHelper

        identity  :id
          Severity: Minor
          Found in lib/fog/profitbricks/models/compute/server.rb - About 2 hrs to fix

            Method get_all_flavors has 55 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    def get_all_flavors
          response = Excon::Response.new
          response.status = 200
          response.body   = {
            'getAllFlavorsResponse' => [
            Severity: Major
            Found in lib/fog/profitbricks/requests/compute/get_all_flavors.rb - About 2 hrs to fix

              Method get_flavor has 55 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      def get_flavor(flavor_id)
          response        = Excon::Response.new
          response.status = 200
          response.body   = {
            "getFlavorResponse" => [
              Severity: Major
              Found in lib/fog/profitbricks/requests/compute/get_flavor.rb - About 2 hrs to fix

                Method create_volume has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        def create_volume(datacenter_id, options = {})
          response = Excon::Response.new
          response.status = 202

          if options[:size] == nil
                Severity: Minor
                Found in lib/fog/profitbricks/requests/compute/create_volume.rb - About 2 hrs to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    module Compute
    class ProfitBricks
      class Real
        # Update LAN properties
        #
                  Severity: Major
                  Found in lib/fog/profitbricks/requests/compute/update_lan.rb and 1 other location - About 1 hr to fix
                  lib/fog/profitbricks/requests/compute/update_load_balancer.rb on lines 2..63

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 76.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    module Compute
    class ProfitBricks
      class Real
        # Update a load balancer
        #
                  Severity: Major
                  Found in lib/fog/profitbricks/requests/compute/update_load_balancer.rb and 1 other location - About 1 hr to fix
                  lib/fog/profitbricks/requests/compute/update_lan.rb on lines 2..120

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 76.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                                {
                'flavorId' => '00db4c8f-5e83-49b0-a70b-ac4aad786163',
                'flavorName' => 'Micro',
                'ram'        => 1024,
                'cores'      => 1
                  Severity: Major
                  Found in lib/fog/profitbricks/requests/compute/get_all_flavors.rb and 1 other location - About 1 hr to fix
                  lib/fog/profitbricks/requests/compute/get_flavor.rb on lines 10..56

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 73.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                                {
                "flavorId"   => "00db4c8f-5e83-49b0-a70b-ac4aad786163",
                "flavorName" => "Micro",
                "ram"        => 1024,
                "cores"      => 1
                  Severity: Major
                  Found in lib/fog/profitbricks/requests/compute/get_flavor.rb and 1 other location - About 1 hr to fix
                  lib/fog/profitbricks/requests/compute/get_all_flavors.rb on lines 10..56

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 73.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method create_user has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          def create_user(options = {})
          if options[:email] == nil
            raise Excon::Error::HTTPStatus, "Attribute 'email' is required"
          end
                  Severity: Minor
                  Found in lib/fog/profitbricks/requests/compute/create_user.rb - About 1 hr to fix

                    Method create_volume_snapshot has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            def create_volume_snapshot(datacenter_id, _volume_id, options = {})
          response = Excon::Response.new
          response.status = 202

          if datacenter = data[:datacenters]['items'].find do |attrib|
                    Severity: Minor
                    Found in lib/fog/profitbricks/requests/compute/create_volume_snapshot.rb - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language