Sign upLogin

fog/fog-radosgw

View on GitHub
Star

Showing 12 of 12 total issues

Method signature has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

      def signature(params, expires)
        headers = params[:headers] || {}

        string_to_sign = [
          params[:method].to_s.upcase,
Severity: Minor
Found in lib/fog/radosgw/utils.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        def delete_user(user_id)
          path         = "admin/user"
          user_id      = escape(user_id)
          query        = "?uid=#{user_id}&format=json"
          params       = {
Severity: Major
Found in lib/fog/radosgw/requests/provisioning/delete_user.rb and 1 other location - About 2 hrs to fix
lib/fog/radosgw/requests/provisioning/get_user.rb on lines 8..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        def get_user(user_id)
          path = "admin/user"
          user_id = escape(user_id)
          query = "?uid=#{user_id}&format=json"
          params = {
Severity: Major
Found in lib/fog/radosgw/requests/provisioning/get_user.rb and 1 other location - About 2 hrs to fix
lib/fog/radosgw/requests/provisioning/delete_user.rb on lines 7..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method signature has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def signature(params, expires)
        headers = params[:headers] || {}

        string_to_sign = [
          params[:method].to_s.upcase,
Severity: Minor
Found in lib/fog/radosgw/utils.rb - About 1 hr to fix

    Method create_user has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def create_user(user_id, display_name, email, options = {})
          if user_exists?(user_id)
            raise Fog::Radosgw::Provisioning::UserAlreadyExists, "User with user_id #{user_id} already exists."
          end
    Severity: Minor
    Found in lib/fog/radosgw/requests/provisioning/create_user.rb - About 1 hr to fix

      Method create_user has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def create_user(user_id, display_name, email, options = {})
          if get_user(user_id).status != 404
            raise Fog::Radosgw::Provisioning::UserAlreadyExists, "User with user_id #{user_id} already exists."
          end
      Severity: Minor
      Found in lib/fog/radosgw/requests/provisioning/create_user.rb - About 1 hr to fix

        Method request has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

                def request(params, parse_response = true, &block)
          begin
            response = @connection.request(params.merge({
              :host     => @host,
              :path     => "#{@path}/#{params[:path]}",
        Severity: Minor
        Found in lib/fog/radosgw/provisioning.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                      response.body = {
                "email"        => value[:email],
                "user_id"      => value[:user_id],
                "display_name" => value[:display_name],
                "suspended"    => value[:suspended],
        Severity: Minor
        Found in lib/fog/radosgw/requests/provisioning/get_user.rb and 1 other location - About 25 mins to fix
        lib/fog/radosgw/requests/provisioning/list_users.rb on lines 50..62

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                      {
                "email"        => value[:email],
                "display_name" => value[:user_id],
                "user_id"      => value[:user_id],
                "suspended"    => value[:suspended],
        Severity: Minor
        Found in lib/fog/radosgw/requests/provisioning/list_users.rb and 1 other location - About 25 mins to fix
        lib/fog/radosgw/requests/provisioning/get_user.rb on lines 41..53

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method get_usage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def get_usage(access_key_id, options = {})
          path = "admin/usage"
          t_now = Fog::Time.now
          start_time  = sanitize_and_convert_time(options[:start_time] || t_now - 86400)
          end_time    = sanitize_and_convert_time(options[:end_time]   || t_now)
        Severity: Minor
        Found in lib/fog/radosgw/requests/usage/get_usage.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          module Radosgw
    class Provisioning
      class Real
        include Utils
        include UserUtils
        Severity: Minor
        Found in lib/fog/radosgw/requests/provisioning/enable_user.rb and 1 other location - About 15 mins to fix
        lib/fog/radosgw/requests/provisioning/disable_user.rb on lines 2..18

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          module Radosgw
    class Provisioning
      class Real
        include Utils
        include UserUtils
        Severity: Minor
        Found in lib/fog/radosgw/requests/provisioning/disable_user.rb and 1 other location - About 15 mins to fix
        lib/fog/radosgw/requests/provisioning/enable_user.rb on lines 2..18

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language