Sign upLogin

fog/fog-vsphere

View on GitHub
Star

Showing 128 of 128 total issues

Method vm_clone has a Cognitive Complexity of 418 (exceeds 5 allowed). Consider refactoring.
Open

        def vm_clone(options = {})
          # Option handling
          options = vm_clone_check_options(options)

          # Options['template_path']<~String>
Severity: Minor
Found in lib/fog/vsphere/requests/compute/vm_clone.rb - About 1 wk to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method vm_clone has 376 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def vm_clone(options = {})
          # Option handling
          options = vm_clone_check_options(options)

          # Options['template_path']<~String>
Severity: Major
Found in lib/fog/vsphere/requests/compute/vm_clone.rb - About 1 day to fix

    File compute.rb has 694 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'digest/sha2'
# rubocop:disable Lint/RescueWithoutErrorClass
# rubocop:disable Metrics/ModuleLength
module Fog
  module Vsphere
    Severity: Major
    Found in lib/fog/vsphere/compute.rb - About 1 day to fix

      Method data has 266 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def self.data
          @data ||= Hash.new do |hash, key|
            hash[key] = {
              servers: {
                '5032c8a5-9c5e-ba7a-3804-832a03e16381' => {
      Severity: Major
      Found in lib/fog/vsphere/compute.rb - About 1 day to fix

        File vm_clone.rb has 558 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        module Fog
  module Vsphere
    class Compute
      module Shared
        private
        Severity: Major
        Found in lib/fog/vsphere/requests/compute/vm_clone.rb - About 1 day to fix

          Class Server has 48 methods (exceeds 20 allowed). Consider refactoring.
          Open

                class Server < Fog::Compute::Server
        extend Fog::Deprecation
        deprecate(:ipaddress, :public_ip_address)
        deprecate(:scsi_controller, :scsi_controllers)
          Severity: Minor
          Found in lib/fog/vsphere/models/compute/server.rb - About 6 hrs to fix

            Method props_to_attr_hash has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
            Open

                    def props_to_attr_hash(vm_mob_ref, props)
          # NOTE: Object.tap is in 1.8.7 and later.
          # Here we create the hash object that this method returns, but first we need
          # to add a few more attributes that require additional calls to the vSphere
          # API. The hypervisor name and mac_addresses attributes may not be available
            Severity: Minor
            Found in lib/fog/vsphere/compute.rb - About 5 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            File create_vm.rb has 319 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            module Fog
  module Vsphere
    class Compute
      class Real
        def create_vm(attributes = {})
            Severity: Minor
            Found in lib/fog/vsphere/requests/compute/create_vm.rb - About 3 hrs to fix

              Method vm_clone_check_options has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
              Open

                      def vm_clone_check_options(options)
          default_options = {
            'force'        => false,
            'linked_clone' => false,
            'nic_type' => 'VirtualE1000'
              Severity: Minor
              Found in lib/fog/vsphere/requests/compute/vm_clone.rb - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File server.rb has 291 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              require 'fog/compute/models/server'

module Fog
  module Vsphere
    class Compute
              Severity: Minor
              Found in lib/fog/vsphere/models/compute/server.rb - About 3 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  module Vsphere
    class Compute
      class Real
        def destroy_group(attributes = {})
          cluster = get_raw_cluster(attributes[:cluster], attributes[:datacenter])
                Severity: Major
                Found in lib/fog/vsphere/requests/compute/destroy_group.rb and 1 other location - About 2 hrs to fix
                lib/fog/vsphere/requests/compute/destroy_rule.rb on lines 2..22

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 95.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  module Vsphere
    class Compute
      class Real
        def destroy_rule(attributes = {})
          cluster = get_raw_cluster(attributes[:cluster], attributes[:datacenter])
                Severity: Major
                Found in lib/fog/vsphere/requests/compute/destroy_rule.rb and 1 other location - About 2 hrs to fix
                lib/fog/vsphere/requests/compute/destroy_group.rb on lines 2..22

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 95.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method props_to_attr_hash has 62 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        def props_to_attr_hash(vm_mob_ref, props)
          # NOTE: Object.tap is in 1.8.7 and later.
          # Here we create the hash object that this method returns, but first we need
          # to add a few more attributes that require additional calls to the vSphere
          # API. The hypervisor name and mac_addresses attributes may not be available
                Severity: Major
                Found in lib/fog/vsphere/compute.rb - About 2 hrs to fix

                  Method cloudinit_to_customspec has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                  Open

                          def cloudinit_to_customspec(user_data)
          raise ArgumentError, "user_data can't be nil" if user_data.nil?
          custom_spec = { 'customization_spec' => {} }
          user_data = YAML.safe_load(user_data)
          # https://pubs.vmware.com/vsphere-55/index.jsp#com.vmware.wssdk.apiref.doc/vim.vm.customization.Specification.html
                  Severity: Minor
                  Found in lib/fog/vsphere/requests/compute/cloudinit_to_customspec.rb - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method get_raw_interface has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                  Open

                          def get_raw_interface(vm_id, options = {})
          raise ArgumentError, 'instance id is a required parameter' unless vm_id

          if options.is_a? Fog::Vsphere::Compute::Interface
            options
                  Severity: Minor
                  Found in lib/fog/vsphere/requests/compute/list_vm_interfaces.rb - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method cloudinit_to_customspec has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                          def cloudinit_to_customspec(user_data)
          raise ArgumentError, "user_data can't be nil" if user_data.nil?
          custom_spec = { 'customization_spec' => {} }
          user_data = YAML.safe_load(user_data)
          custom_spec['encryptionKey']                = user_data['encryptionKey'] if user_data.key?('encryptionKey')
                  Severity: Minor
                  Found in lib/fog/vsphere/requests/compute/cloudinit_to_customspec.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method list_networks has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                          def list_networks(filters = {})
          datacenter_name = filters[:datacenter]
          cluster_name = filters.fetch(:cluster, nil)
          # default to show all networks
          only_active = filters[:accessible] || false
                  Severity: Minor
                  Found in lib/fog/vsphere/requests/compute/list_networks.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method create_vm has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                          def create_vm(attributes = {})
          # build up vm configuration
          cluster = get_raw_cluster(attributes[:cluster], attributes[:datacenter])
          raise Fog::Vsphere::Compute::NotFound, "Cluster #{attributes[:cluster]} Doesn't Exist in the DC!" unless cluster
                  Severity: Minor
                  Found in lib/fog/vsphere/requests/compute/create_vm.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method vm_relocate has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                          def vm_relocate(options = {})
          raise ArgumentError, 'instance_uuid is a required parameter' unless options.key? 'instance_uuid'

          # Find the VM Object
          search_filter = { :uuid => options['instance_uuid'], 'vmSearch' => true, 'instanceUuid' => true }
                  Severity: Minor
                  Found in lib/fog/vsphere/requests/compute/vm_relocate.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method list_compute_resources has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          def list_compute_resources(_filters = {})
          [
            {
              id: 'domain-s7',
              name: 'fake-host',
                  Severity: Minor
                  Found in lib/fog/vsphere/requests/compute/list_compute_resources.rb - About 1 hr to fix
                    Severity
                    Category
                    Status
                    Source
                    Language