Sign upLogin

fog/fog-xenserver

View on GitHub
Star

Showing 81 of 81 total issues

Method import_convert_server has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def import_convert_server(type, username, password, sr, remote_config)
Severity: Minor
Found in lib/fog/xenserver/compute/requests/import_convert_server.rb - About 35 mins to fix

    Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def initialize(host, port, use_ssl, verify_mode, timeout)
    Severity: Minor
    Found in lib/fog/xenserver/connection.rb - About 35 mins to fix

      Method set_memory_limits_server has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def set_memory_limits_server(ref, static_min, static_max, dynamic_min, dynamic_max)
      Severity: Minor
      Found in lib/fog/xenserver/compute/requests/set_memory_limits_server.rb - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          module XenServer
    class Compute
      class Real
        def db_introduce_vdi(uuid, name_label, name_description, sr, type, sharable, read_only, other_config, location, xenstore_data, sm_config, managed, virtual_size, physical_utilisation, metadata_of_pool, is_a_snapshot, snapshot_time, snapshot_of)
          @connection.request({ :parser => Fog::XenServer::Parsers::Base.new, :method => "VDI.db_introduce" }, uuid, name_label, name_description, sr, type, sharable, read_only, other_config, location, xenstore_data, sm_config, managed, virtual_size, physical_utilisation, metadata_of_pool, is_a_snapshot, snapshot_time, snapshot_of)
        Severity: Minor
        Found in lib/fog/xenserver/compute/requests/db_introduce_vdi.rb and 1 other location - About 35 mins to fix
        lib/fog/xenserver/compute/requests/introduce_vdi.rb on lines 2..6

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          module XenServer
    class Compute
      class Real
        def introduce_vdi(uuid, name_label, name_description, sr, type, sharable, read_only, other_config, location, xenstore_data, sm_config, managed, virtual_size, physical_utilisation, metadata_of_pool, is_a_snapshot, snapshot_time, snapshot_of)
          @connection.request({ :parser => Fog::XenServer::Parsers::Base.new, :method => "VDI.introduce" }, uuid, name_label, name_description, sr, type, sharable, read_only, other_config, location, xenstore_data, sm_config, managed, virtual_size, physical_utilisation, metadata_of_pool, is_a_snapshot, snapshot_time, snapshot_of)
        Severity: Minor
        Found in lib/fog/xenserver/compute/requests/introduce_vdi.rb and 1 other location - About 35 mins to fix
        lib/fog/xenserver/compute/requests/db_introduce_vdi.rb on lines 2..6

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid parameter lists longer than 5 parameters. [6/5]
        Open

                def migrate_send_server(ref, dest, live, vdi_map, vif_map, options)
        Severity: Minor
        Found in lib/fog/xenserver/compute/requests/migrate_send_server.rb by rubocop

        This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

        Avoid parameter lists longer than 5 parameters. [6/5]
        Open

                def assert_can_migrate_server(ref, dest, live, vdi_map, vif_map, options)
        Severity: Minor
        Found in lib/fog/xenserver/compute/requests/assert_can_migrate_server.rb by rubocop

        This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

        Avoid parameter lists longer than 5 parameters. [6/5]
        Open

                def introduce_sr(uuid, name_label, name_description, typecontent, sahred, sm_config)
        Severity: Minor
        Found in lib/fog/xenserver/compute/requests/introduce_sr.rb by rubocop

        This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  def get_by_uuid(uuid)
            ref = service.get_by_uuid(uuid, model.provider_class)
            return nil if ref.nil?
            get(ref)
          rescue Fog::XenServer::NotFound, Fog::XenServer::RequestFailed
        Severity: Minor
        Found in lib/fog/xenserver/compute/models/collection.rb and 1 other location - About 15 mins to fix
        lib/fog/xenserver/compute/models/collection.rb on lines 18..23

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  def get_by_name(name)
            ref = service.get_by_name(name, model.provider_class)
            return nil if ref.nil?
            get(ref)
          rescue Fog::XenServer::NotFound, Fog::XenServer::RequestFailed
        Severity: Minor
        Found in lib/fog/xenserver/compute/models/collection.rb and 1 other location - About 15 mins to fix
        lib/fog/xenserver/compute/models/collection.rb on lines 28..33

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          module XenServer
    class Compute
      class Real
        def migrate_send_server(ref, dest, live, vdi_map, vif_map, options)
          @connection.request({ :parser => Fog::XenServer::Parsers::Base.new, :method => "VM.migrate_send" }, ref, dest, live, vdi_map, vif_map, options)
        Severity: Minor
        Found in lib/fog/xenserver/compute/requests/migrate_send_server.rb and 1 other location - About 15 mins to fix
        lib/fog/xenserver/compute/requests/assert_can_migrate_server.rb on lines 2..10

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          module XenServer
    class Compute
      class Real
        def assert_can_migrate_server(ref, dest, live, vdi_map, vif_map, options)
          @connection.request({ :parser => Fog::XenServer::Parsers::Base.new, :method => "VM.assert_can_migrate" }, ref, dest, live, vdi_map, vif_map, options)
        Severity: Minor
        Found in lib/fog/xenserver/compute/requests/assert_can_migrate_server.rb and 1 other location - About 15 mins to fix
        lib/fog/xenserver/compute/requests/migrate_send_server.rb on lines 2..10

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
        Open

        lib = File.expand_path('../lib', __FILE__)
        Severity: Minor
        Found in fog-xenserver.gemspec by rubocop

        Checks if uses of quotes match the configured preference.

        Example: EnforcedStyle: single_quotes (default)

        # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

        Example: EnforcedStyle: double_quotes

        # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

        Put one space between the method name and the first argument.
        Open

                  has_many_identities  :vms,  :servers,      :aliases => :VMs,  :as => :VMs
        Severity: Minor
        Found in lib/fog/xenserver/compute/models/vmpp.rb by rubocop

        Checks that exactly one space is used between a method name and the first argument for method calls without parentheses.

        Alternatively, extra spaces can be added to align the argument with something on a preceding or following line, if the AllowForAlignment config parameter is true.

        Example:

        # bad
something  x
something   y, z
something'hello'

# good
something x
something y, z
something 'hello'

        Unused method argument - extra_params. If it's necessary, use _ or _extra_params as an argument name to indicate that it won't be used.
        Open

                def create_network(config = {}, extra_params = {})
        Severity: Minor
        Found in lib/fog/xenserver/compute/requests/create_network.rb by rubocop

        This cop checks for unused method arguments.

        Example:

        # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

        Example:

        # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

        Useless assignment to variable - e.
        Open

                rescue Fog::XenServer::RequestFailed => e
        Severity: Minor
        Found in lib/fog/xenserver/compute/requests/builtin_templates.rb by rubocop

        This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

        assigned but unused variable - foo

        Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

        Example:

        # bad

def some_method
  some_var = 1
  do_something
end

        Example:

        # good

def some_method
  some_var = 1
  do_something(some_var)
end

        Unused method argument - options. If it's necessary, use _ or _options as an argument name to indicate that it won't be used.
        Open

                def get_records(klass, options = {})
        Severity: Minor
        Found in lib/fog/xenserver/compute/requests/get_records.rb by rubocop

        This cop checks for unused method arguments.

        Example:

        # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

        Example:

        # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

        Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
        Open

          t.test_files = FileList['spec/**/*_spec.rb']
        Severity: Minor
        Found in Rakefile by rubocop

        Checks if uses of quotes match the configured preference.

        Example: EnforcedStyle: single_quotes (default)

        # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

        Example: EnforcedStyle: double_quotes

        # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

        Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
        Open

        desc 'Default Task'
        Severity: Minor
        Found in Rakefile by rubocop

        Checks if uses of quotes match the configured preference.

        Example: EnforcedStyle: single_quotes (default)

        # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

        Example: EnforcedStyle: double_quotes

        # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

        Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
        Open

          spec.add_development_dependency 'vcr'
        Severity: Minor
        Found in fog-xenserver.gemspec by rubocop

        Checks if uses of quotes match the configured preference.

        Example: EnforcedStyle: single_quotes (default)

        # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

        Example: EnforcedStyle: double_quotes

        # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"
        Severity
        Category
        Status
        Source
        Language