Sign upLogin

fog/fog-xenserver

View on GitHub
Star
lib/fog/xenserver/compute/requests/db_introduce_vdi.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method db_introduce_vdi has 18 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def db_introduce_vdi(uuid, name_label, name_description, sr, type, sharable, read_only, other_config, location, xenstore_data, sm_config, managed, virtual_size, physical_utilisation, metadata_of_pool, is_a_snapshot, snapshot_time, snapshot_of)
Severity: Major
Found in lib/fog/xenserver/compute/requests/db_introduce_vdi.rb - About 2 hrs to fix

    Avoid parameter lists longer than 5 parameters. [18/5]
    Open

            def db_introduce_vdi(uuid, name_label, name_description, sr, type, sharable, read_only, other_config, location, xenstore_data, sm_config, managed, virtual_size, physical_utilisation, metadata_of_pool, is_a_snapshot, snapshot_time, snapshot_of)
    Severity: Minor
    Found in lib/fog/xenserver/compute/requests/db_introduce_vdi.rb by rubocop

    This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      module XenServer
    class Compute
      class Real
        def db_introduce_vdi(uuid, name_label, name_description, sr, type, sharable, read_only, other_config, location, xenstore_data, sm_config, managed, virtual_size, physical_utilisation, metadata_of_pool, is_a_snapshot, snapshot_time, snapshot_of)
          @connection.request({ :parser => Fog::XenServer::Parsers::Base.new, :method => "VDI.db_introduce" }, uuid, name_label, name_description, sr, type, sharable, read_only, other_config, location, xenstore_data, sm_config, managed, virtual_size, physical_utilisation, metadata_of_pool, is_a_snapshot, snapshot_time, snapshot_of)
    Severity: Minor
    Found in lib/fog/xenserver/compute/requests/db_introduce_vdi.rb and 1 other location - About 35 mins to fix
    lib/fog/xenserver/compute/requests/introduce_vdi.rb on lines 2..6

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status