Sign upLogin

fog/fog

View on GitHub
Star
lib/fog/opennebula/requests/compute/OpenNebulaVNC.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method start has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def start
        if is_running?
            message="VNC server already running"
            STDERR.puts message
            @logger.info message
Severity: Minor
Found in lib/fog/opennebula/requests/compute/OpenNebulaVNC.rb - About 1 hr to fix

    Method start has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def start
        if is_running?
            message="VNC server already running"
            STDERR.puts message
            @logger.info message
    Severity: Minor
    Found in lib/fog/opennebula/requests/compute/OpenNebulaVNC.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method proxy has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def proxy(vm_resource)
        # Check configurations and VM attributes
        #if !is_running?
        #    return error(400, "VNC Proxy is not running")
        #end
    Severity: Minor
    Found in lib/fog/opennebula/requests/compute/OpenNebulaVNC.rb - About 1 hr to fix

      Method stop has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def stop(force=false)
        pid=get_pid

        if pid
            @logger.info "Killing VNC proxy"
      Severity: Minor
      Found in lib/fog/opennebula/requests/compute/OpenNebulaVNC.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status