Sign upLogin

fogine/couchbase-odm

View on GitHub
Star

Showing 72 of 72 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

UUID4Key.prototype.setId = function(id) {
    if (id !== undefined) {
        let regx = /^[0-9a-f]{8}-[0-9a-f]{4}-[1-5][0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/i;
        if ((id + '').match(regx) === null) {
            throw new KeyError('Failed to set `id`. The value is not in format of uuidv4, got: ' + id);
Severity: Major
Found in lib/key/uuid4Key.js and 1 other location - About 3 hrs to fix
lib/key/incrementalKey.js on lines 34..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function cloneDefaults has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

function cloneDefaults(data) {
    var cloned;

    if (!_.isPlainObject(data) && !Array.isArray(data)) {
        if (data instanceof Instance) {
Severity: Minor
Found in lib/util/data.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Model.prototype.unlock = Promise.method(function(id, cas) {
    let key = id;
    if (!(id instanceof this.Key)) {
        key = this.buildKey(id);
    }
Severity: Major
Found in lib/model.js and 1 other location - About 2 hrs to fix
lib/model.js on lines 709..716

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Model.prototype.touch = Promise.method(function(id, expiry) {
    let key = id;
    if (!(id instanceof this.Key)) {
        key = this.buildKey(id);
    }
Severity: Major
Found in lib/model.js and 1 other location - About 2 hrs to fix
lib/model.js on lines 725..732

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _getDirtyRefDocs has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Instance.prototype._getDirtyRefDocs = Promise.method(function() {

    const self = this;
    const out = {
        current: [],//collection of current ref-documents which will be persisted to the bucket
Severity: Major
Found in lib/instance.js - About 2 hrs to fix

    Function getByIdOrFail has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Model.prototype.getByIdOrFail = Promise.method(function(id, options) {
    let key = id;
    const actions = [];
    const defaults = {
        paranoid: true,
    Severity: Major
    Found in lib/model.js - About 2 hrs to fix

      Function build has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function build(options) {
    const defaults = {
        _data: true, //data json references
        allErrors: false,
        verbose: true, //include validated data in errors
      Severity: Major
      Found in lib/validator.js - About 2 hrs to fix

        Function Model has 58 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function Model(name, schema, options) {

    if (!name || (typeof name !== "string" && !(name instanceof String) )) {
        throw new ModelError("Model's name must be non-empty string value");
    }
        Severity: Major
        Found in lib/model.js - About 2 hrs to fix

          Function _init has 57 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          Model.prototype._init = function(modelManager) {

    const self = this;

    this._modelManager = modelManager;
          Severity: Major
          Found in lib/model.js - About 2 hrs to fix

            Function Instance has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function Instance(data, options) {

    Document.call(this, {
        data        : data,
        key         : options.key,
            Severity: Major
            Found in lib/instance.js - About 2 hrs to fix

              Function replace has 53 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              Instance.prototype.replace = Promise.method(function(options) {

    const self = this;
    let timestampsBck;
    options = options || {};
              Severity: Major
              Found in lib/instance.js - About 2 hrs to fix

                File storageAdapter.js has 254 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                var Promise    = require("bluebird");
var Key        = require("./key/key.js");
var Document   = require("./document.js");
var _          = require("lodash");
var couchbase  = require('couchbase');
                Severity: Minor
                Found in lib/storageAdapter.js - About 2 hrs to fix

                  Function _extract has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function _extract(schema, keywords, _skipDefaults) {
    let out = {};
    keywords = keywords || {};
    if (typeof _skipDefaults !== 'boolean') {
        _skipDefaults = true;
                  Severity: Minor
                  Found in lib/util/schema.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function _initRelations has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                  Instance.prototype._initRelations =  function() {
    const idPropName   = this._schemaSettings.doc.idPropertyName;
    const modelManager = this.Model._modelManager;
    const relations    = this.Model.relations;
    const dataValues   = this.getData();
                  Severity: Minor
                  Found in lib/instance.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getMulti has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  Model.prototype.getMulti = Promise.method(function(ids, options) {

    const defaults = {
        indexed         : true,
        hooks           : true,
                  Severity: Minor
                  Found in lib/model.js - About 1 hr to fix

                    Function extractAssociations has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function extractAssociations(schema, data, path) {
    data || (data = []);
    path || (path = []);

    if (!_.isPlainObject(schema)) {
                    Severity: Minor
                    Found in lib/util/schema.js - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function _extract has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function _extract(schema, keywords, _skipDefaults) {
    let out = {};
    keywords = keywords || {};
    if (typeof _skipDefaults !== 'boolean') {
        _skipDefaults = true;
                    Severity: Minor
                    Found in lib/util/schema.js - About 1 hr to fix

                      Similar blocks of code found in 8 locations. Consider refactoring.
                      Open

                      function InstanceError(message) {

    DocumentError.call(this);
    Error.captureStackTrace(this, this.constructor);
                      Severity: Major
                      Found in lib/error/instanceError.js and 7 other locations - About 1 hr to fix
                      lib/error/documentError.js on lines 11..18
                      lib/error/hookError.js on lines 11..18
                      lib/error/keyError.js on lines 11..18
                      lib/error/modelError.js on lines 11..18
                      lib/error/modelManagerError.js on lines 11..18
                      lib/error/modelNotFoundError.js on lines 11..18
                      lib/error/validationError.js on lines 11..18

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 68.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 8 locations. Consider refactoring.
                      Open

                      function ModelError(message) {

    Error.call(this);
    Error.captureStackTrace(this, this.constructor);
                      Severity: Major
                      Found in lib/error/modelError.js and 7 other locations - About 1 hr to fix
                      lib/error/documentError.js on lines 11..18
                      lib/error/hookError.js on lines 11..18
                      lib/error/instanceError.js on lines 14..21
                      lib/error/keyError.js on lines 11..18
                      lib/error/modelManagerError.js on lines 11..18
                      lib/error/modelNotFoundError.js on lines 11..18
                      lib/error/validationError.js on lines 11..18

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 68.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 8 locations. Consider refactoring.
                      Open

                      function DocumentError(message) {

    Error.call(this);
    Error.captureStackTrace(this, this.constructor);
                      Severity: Major
                      Found in lib/error/documentError.js and 7 other locations - About 1 hr to fix
                      lib/error/hookError.js on lines 11..18
                      lib/error/instanceError.js on lines 14..21
                      lib/error/keyError.js on lines 11..18
                      lib/error/modelError.js on lines 11..18
                      lib/error/modelManagerError.js on lines 11..18
                      lib/error/modelNotFoundError.js on lines 11..18
                      lib/error/validationError.js on lines 11..18

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 68.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language