lib/excavate/extractors/cpio/cpio_old_format.rb
File cpio_old_format.rb
has 352 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
require 'stringio'
module CPIO
class ArchiveFormatError < IOError; end
Method to_data
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def to_data
Fields.collect do |(width,name)|
raise ArchiveFormatError, "Expected header to have key #{name}" unless @attrs.has_key?(name)
val = @attrs[name].respond_to?(:to_proc) ? @attrs[name].call : @attrs[name]
raise ArchiveFormatError, "Header value for #{name} exceeds max length of #{FieldMaxValues[name]}" if val > FieldMaxValues[name]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"