Sign upLogin

foodcoop-adam/foodsoft

View on GitHub
Star
app/controllers/orders_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Method update_order_amounts has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

  def update_order_amounts
    return if not params[:order_articles]
    # where to leave remainder during redistribution
    rest_to = []
    rest_to << :tolerance if params[:rest_to_tolerance]
Severity: Minor
Found in app/controllers/orders_controller.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_order_amounts has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def update_order_amounts
    return if not params[:order_articles]
    # where to leave remainder during redistribution
    rest_to = []
    rest_to << :tolerance if params[:rest_to_tolerance]
Severity: Minor
Found in app/controllers/orders_controller.rb - About 1 hr to fix

    Method finish has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def finish
    @order = Order.find params[:id]
    @order_info = params[:order_info] || {}
    @order_info[:sender_name] ||= @current_user.name
    @order_info[:order_contact_name] ||= @current_user.name
    Severity: Minor
    Found in app/controllers/orders_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method show has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def show
    @order= Order.find(params[:id])
    @view = (params[:view] or 'default').gsub(/[^-_a-zA-Z0-9]/, '')
    @partial = case @view
                 when 'default'  then 'articles'
    Severity: Minor
    Found in app/controllers/orders_controller.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status