Sign upLogin

foodcoop-adam/foodsoft

View on GitHub
Star
app/models/order.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Order has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

class Order < ActiveRecord::Base
  attr_accessor :ignore_warnings

  # Associations
  has_many :order_articles, :dependent => :destroy
Severity: Minor
Found in app/models/order.rb - About 3 hrs to fix

    Method sum has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

      def sum(type = :gross)
    total = 0
    if type == :net || type == :gross || type == :fc
      for oa in order_articles.ordered.includes(:article, :article_price)
        quantity = oa.units * oa.price.unit_quantity
    Severity: Minor
    Found in app/models/order.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method order_send_emails has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def order_send_emails
    return unless FoodsoftConfig[:send_order_on_finish]
    return unless supplier.order_send_email or FoodsoftConfig[:send_order_on_finish] == 'cc_only'
    to = FoodsoftConfig[:send_order_on_finish_cc] || []
    to.map! do |a|
    Severity: Minor
    Found in app/models/order.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method sum has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def sum(type = :gross)
    total = 0
    if type == :net || type == :gross || type == :fc
      for oa in order_articles.ordered.includes(:article, :article_price)
        quantity = oa.units * oa.price.unit_quantity
    Severity: Minor
    Found in app/models/order.rb - About 1 hr to fix

      Method close! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def close!(user)
    raise I18n.t('orders.model.error_closed') if closed?
    transaction_note = I18n.t('orders.model.notice_close', :name => name,
                              :ends => ends.strftime(I18n.t('date.formats.default')))
      Severity: Minor
      Found in app/models/order.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method starts_and_ends_before_pickup has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def starts_and_ends_before_pickup
    return unless pickup
    if ends
      errors.add(:pickup, I18n.t('orders.model.error_ends_before_pickup')) if pickup <= ends
    elsif starts
      Severity: Minor
      Found in app/models/order.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                case type
            when :groups
              total += goa.result * goa.order_article.price.fc_price(goa.group_order.ordergroup)
            when :groups_without_markup
              total += goa.result * goa.order_article.price.gross_price(goa.group_order.ordergroup)
      Severity: Major
      Found in app/models/order.rb - About 45 mins to fix

        Method keep_ordered_articles has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def keep_ordered_articles
    chosen_order_articles = order_articles.find_all_by_article_id(article_ids)
    to_be_removed = order_articles - chosen_order_articles
    to_be_removed_but_ordered = to_be_removed.select { |a| a.quantity > 0 or a.tolerance > 0 }
    unless to_be_removed_but_ordered.empty? or ignore_warnings
        Severity: Minor
        Found in app/models/order.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method init_dates has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def init_dates
    self.starts ||= Time.now
    if FoodsoftConfig[:order_schedule]
      # try to be smart when picking a reference day
      last = FoodsoftConfig[:order_schedule]['initial'].try(:to_time)
        Severity: Minor
        Found in app/models/order.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status