Sign upLogin

foodcoop-adam/foodsoft

View on GitHub
Star
lib/foodsoft_file.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method ensure_file_format has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def self.ensure_file_format(file, opts={})
    # catch original filename from uploaded files (see `Http::UploadedFile`)
    if file.respond_to?(:tempfile)
      filename = file.original_filename
      file = file.tempfile
Severity: Minor
Found in lib/foodsoft_file.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def self.parse(file, opts={})
    articles, outlisted_articles = Array.new, Array.new
    row_index = 2
    data = read_file file, opts
    col_sep = csv_guess_col_sep data
Severity: Minor
Found in lib/foodsoft_file.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ensure_file_format has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.ensure_file_format(file, opts={})
    # catch original filename from uploaded files (see `Http::UploadedFile`)
    if file.respond_to?(:tempfile)
      filename = file.original_filename
      file = file.tempfile
Severity: Minor
Found in lib/foodsoft_file.rb - About 1 hr to fix

    Method parse has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.parse(file, opts={})
    articles, outlisted_articles = Array.new, Array.new
    row_index = 2
    data = read_file file, opts
    col_sep = csv_guess_col_sep data
    Severity: Minor
    Found in lib/foodsoft_file.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status