foodcoop-adam/foodsoft

View on GitHub
lib/foodsoft_userinfo/examples/phpbb3_auth_foodsoft.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method autologin_foodsoft has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function autologin_foodsoft()
{
  global $db;

  $foodsoftUser = get_foodsoft_user();
Severity: Minor
Found in lib/foodsoft_userinfo/examples/phpbb3_auth_foodsoft.php - About 1 hr to fix

    Function autologin_foodsoft has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    function autologin_foodsoft()
    {
      global $db;
    
      $foodsoftUser = get_foodsoft_user();
    Severity: Minor
    Found in lib/foodsoft_userinfo/examples/phpbb3_auth_foodsoft.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method login_foodsoft has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function login_foodsoft($username, $password, $ip = '', $borwser = '', $forwarded_for = '')
    Severity: Minor
    Found in lib/foodsoft_userinfo/examples/phpbb3_auth_foodsoft.php - About 35 mins to fix

      Avoid too many return statements within this method.
      Open

          return array();
      Severity: Major
      Found in lib/foodsoft_userinfo/examples/phpbb3_auth_foodsoft.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return $row;
        Severity: Major
        Found in lib/foodsoft_userinfo/examples/phpbb3_auth_foodsoft.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status