Sign upLogin

fortio/dnsping

View on GitHub
Star

Showing 2 of 2 total issues

Function DNSPing has 80 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func DNSPing(cfg *DNSPingConfig) *DNSPingResults {
    m := new(dns.Msg)
    m.SetQuestion(cfg.Query, cfg.QueryType)
    m.RecursionDesired = cfg.Recursion
    qtS := dns.TypeToString[cfg.QueryType]
Severity: Major
Found in dnsping.go - About 2 hrs to fix

    Function JSONSave has 5 return statements (exceeds 4 allowed).
    Open

    func JSONSave(res *DNSPingResults, jsonFileName string) int {
        var j []byte
        j, err := json.MarshalIndent(res, "", "  ")
        if err != nil {
            return log.FErrf("Unable to json serialize result: %v", err)
    Severity: Major
    Found in dnsping.go - About 35 mins to fix
      Severity
      Category
      Status
      Source
      Language