Sign upLogin

fortytools/forty_facets

View on GitHub
Star

Showing 7 of 7 total issues

Class FacetSearch has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

  class FacetSearch
    attr_reader :filters, :orders

    class << self
      def model(model)
Severity: Minor
Found in lib/forty_facets/facet_search.rb - About 3 hrs to fix

    Method apply has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def apply(query)
      if [Symbol, String, Hash].include? definition.clause.class
        query.order(definition.clause)
      elsif definition.clause.is_a? Array # [:person, :first_name]
        # new and unelegant handling of ordering by columns from joined tables
    Severity: Minor
    Found in lib/forty_facets/order.rb - About 1 hr to fix

      Method request_to_search_params has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def request_to_search_params(request_params)
      if request_params && request_params[self.class.request_param_name]
        should_be_hash = request_params[self.class.request_param_name]
        if should_be_hash.respond_to?(:permit!)
          should_be_hash = should_be_hash.permit!.to_h
      Severity: Minor
      Found in lib/forty_facets/facet_search.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method apply has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def apply(query)
      if [Symbol, String, Hash].include? definition.clause.class
        query.order(definition.clause)
      elsif definition.clause.is_a? Array # [:person, :first_name]
        # new and unelegant handling of ordering by columns from joined tables
      Severity: Minor
      Found in lib/forty_facets/order.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method init_associations has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def init_associations
      current_class = search.root_class
      current_association = nil

      joins = []
      Severity: Minor
      Found in lib/forty_facets/filter_definition.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            def remove(value)
        new_params = search_instance.params || {}
        old_values = new_params[definition.request_param]
        old_values.delete(value.to_s)
        new_params.delete(definition.request_param) if old_values.empty?
      Severity: Minor
      Found in lib/forty_facets/filter/facet_filter_definition.rb and 1 other location - About 25 mins to fix
      lib/forty_facets/filter/sql_facet_filter_definition.rb on lines 42..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            def remove(value)
        new_params = search_instance.params || {}
        old_values = new_params[definition.request_param]
        old_values.delete(value.to_s)
        new_params.delete(definition.request_param) if old_values.empty?
      Severity: Minor
      Found in lib/forty_facets/filter/sql_facet_filter_definition.rb and 1 other location - About 25 mins to fix
      lib/forty_facets/filter/facet_filter_definition.rb on lines 78..83

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language