Showing 5 of 7 total issues
Class FacetSearch
has 26 methods (exceeds 20 allowed). Consider refactoring. Open
class FacetSearch
attr_reader :filters, :orders
class << self
def model(model)
Method apply
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def apply(query)
if [Symbol, String, Hash].include? definition.clause.class
query.order(definition.clause)
elsif definition.clause.is_a? Array # [:person, :first_name]
# new and unelegant handling of ordering by columns from joined tables
Method request_to_search_params
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def request_to_search_params(request_params)
if request_params && request_params[self.class.request_param_name]
should_be_hash = request_params[self.class.request_param_name]
if should_be_hash.respond_to?(:permit!)
should_be_hash = should_be_hash.permit!.to_h
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method apply
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def apply(query)
if [Symbol, String, Hash].include? definition.clause.class
query.order(definition.clause)
elsif definition.clause.is_a? Array # [:person, :first_name]
# new and unelegant handling of ordering by columns from joined tables
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method init_associations
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def init_associations
current_class = search.root_class
current_association = nil
joins = []
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"