forumhouseteam/laravel-amqp

View on GitHub

Showing 4 of 4 total issues

Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
Open

        AMQPStreamConnection $connection,
        $defaultQueueName = null,
        $queueFlags = [],
        $declareQueues = true,
        $messageProperties = [],
Severity: Major
Found in src/Queue/AMQPQueue.php - About 1 hr to fix

    Method connect has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function connect(array $config)
        {
            $connection = new AMQPStreamConnection(
                $config['host'],
                $config['port'],
    Severity: Minor
    Found in src/Connectors/AmqpConnector.php - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function addMessageToBatch($job, $data = '', $queue = null)
          {
              $queue = $this->prepareQueue($queue);
              $payload = new AMQPMessage($this->createPayload($job, $queue, $data), $this->messageProperties);
              $this->channel->batch_basic_publish($payload, $this->exchangeName, $this->getRoutingKey($queue));
      Severity: Minor
      Found in src/Queue/AMQPQueue.php and 1 other location - About 55 mins to fix
      src/Queue/AMQPQueue.php on lines 163..170

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 98.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function push($job, $data = '', $queue = null)
          {
              $queue = $this->prepareQueue($queue);
              $payload = new AMQPMessage($this->createPayload($job, $queue, $data), $this->messageProperties);
              $this->channel->basic_publish($payload, $this->exchangeName, $this->getRoutingKey($queue));
      Severity: Minor
      Found in src/Queue/AMQPQueue.php and 1 other location - About 55 mins to fix
      src/Queue/AMQPQueue.php on lines 183..190

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 98.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language