Sign upLogin

fossasia/engelsystem

View on GitHub
Star
includes/controller/admin_groups_controller.php

Summary

Maintainability
C
1 day
Test Coverage

Function admin_groups has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

function admin_groups() {
  global $user;

  $html = "";
  $groups = Groups_by_name();
Severity: Minor
Found in includes/controller/admin_groups_controller.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method admin_groups has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function admin_groups() {
  global $user;

  $html = "";
  $groups = Groups_by_name();
Severity: Major
Found in includes/controller/admin_groups_controller.php - About 3 hrs to fix

    Avoid too many return statements within this method.
    Open

      return $html;
    Severity: Major
    Found in includes/controller/admin_groups_controller.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                return error("No Group found.", true);
      Severity: Major
      Found in includes/controller/admin_groups_controller.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status