Sign upLogin

fossasia/engelsystem

View on GitHub
Star
includes/controller/admin_import_controller.php

Summary

Maintainability
F
3 days
Test Coverage

Function admin_import has a Cognitive Complexity of 62 (exceeds 5 allowed). Consider refactoring.
Open

function admin_import() {
  global $rooms_import;
  global $user;
  $html = "";
Severity: Minor
Found in includes/controller/admin_import_controller.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method admin_import has 218 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function admin_import() {
  global $rooms_import;
  global $user;
  $html = "";
Severity: Major
Found in includes/controller/admin_import_controller.php - About 1 day to fix

    File admin_import_controller.php has 325 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

function admin_import_title() {
  return _("Frab import");
}
    Severity: Minor
    Found in includes/controller/admin_import_controller.php - About 3 hrs to fix

      Method prepare_events has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function prepare_events($file, $shifttype_id, $add_minutes_start, $add_minutes_end) {
  global $rooms_import;
  $data = read_xml($file);

  $rooms = Room_all();
      Severity: Minor
      Found in includes/controller/admin_import_controller.php - About 1 hr to fix

        Function prepare_events has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        function prepare_events($file, $shifttype_id, $add_minutes_start, $add_minutes_end) {
  global $rooms_import;
  $data = read_xml($file);

  $rooms = Room_all();
        Severity: Minor
        Found in includes/controller/admin_import_controller.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

              if ($shift['shifttype_id'] != $tmp['shifttype_id'] || $shift['title'] != $tmp['title'] || $shift['start'] != $tmp['start'] || $shift['end'] != $tmp['end'] || $shift['RID'] != $tmp['RID'] || $shift['URL'] != $tmp['URL'])
        $shifts_updated[] = $shift;
        Severity: Major
        Found in includes/controller/admin_import_controller.php - About 40 mins to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                    table(array(
              'day' => _("Day"),
              'start' => _("Start"),
              'end' => _("End"),
              'shifttype' => _('Shift type'),
          Severity: Major
          Found in includes/controller/admin_import_controller.php and 2 other locations - About 45 mins to fix
          includes/controller/admin_import_controller.php on lines 150..157
          includes/controller/admin_import_controller.php on lines 159..166

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 96.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                    table(array(
              'day' => _("Day"),
              'start' => _("Start"),
              'end' => _("End"),
              'shifttype' => _('Shift type'),
          Severity: Major
          Found in includes/controller/admin_import_controller.php and 2 other locations - About 45 mins to fix
          includes/controller/admin_import_controller.php on lines 150..157
          includes/controller/admin_import_controller.php on lines 168..175

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 96.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                    table(array(
              'day' => _("Day"),
              'start' => _("Start"),
              'end' => _("End"),
              'shifttype' => _('Shift type'),
          Severity: Major
          Found in includes/controller/admin_import_controller.php and 2 other locations - About 45 mins to fix
          includes/controller/admin_import_controller.php on lines 159..166
          includes/controller/admin_import_controller.php on lines 168..175

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 96.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status