fossasia/engelsystem

<?php
 
/**
 * Text for Angeltype related links.
 */
function angeltypes_title() {
  return _("Angeltypes");
}
 
/**
 * Route angeltype actions.
 */
function angeltypes_controller() {
  if (! isset($_REQUEST['action']))
    $_REQUEST['action'] = 'list';
 
  switch ($_REQUEST['action']) {
    default:
    case 'list':
      return angeltypes_list_controller();
    case 'view':
      return angeltype_controller();
    case 'edit':
      return angeltype_edit_controller();
    case 'delete':
      return angeltype_delete_controller();
    case 'about':
Avoid too many `return` statements within this method.
      return angeltypes_about_controller();
  }
}
 
/**
 * Path to angeltype view.
 *
 * @param AngelType $angeltype_id
 */
function angeltype_link($angeltype_id) {
  return page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype_id;
}
 
/**
 * Job description for all angeltypes (public to everyone)
 */
function angeltypes_about_controller() {
  global $privileges, $user;
 
  if (isset($user))
    $angeltypes = AngelTypes_with_user($user);
  else
    $angeltypes = AngelTypes();
  if ($angeltypes === false)
    engelsystem_error("Unable to load angeltypes.");
 
  return array(
      _("Teams/Job description"),
      AngelTypes_about_view($angeltypes, isset($user))
  );
}
 
/**
 * Delete an Angeltype.
 */
Function `angeltype_delete_controller` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
function angeltype_delete_controller() {
  global $privileges, $user;
 
  if (! in_array('admin_angel_types', $privileges))
    redirect(page_link_to('angeltypes'));
 
  $angeltype = AngelType($_REQUEST['angeltype_id']);
  if ($angeltype === false)
    engelsystem_error("Unable to load angeltype.");
  if ($angeltype == null)
    redirect(page_link_to('angeltypes'));
 
  if (isset($_REQUEST['confirmed'])) {
    $result = AngelType_delete($angeltype);
    if ($result === false)
      engelsystem_error("Unable to delete angeltype.");
 
    engelsystem_log("Deleted angeltype: " . AngelType_name_render($angeltype));
    success(sprintf(_("Angeltype %s deleted."), AngelType_name_render($angeltype)));
    redirect(page_link_to('angeltypes'));
  }
 
  return array(
      sprintf(_("Delete angeltype %s"), $angeltype['name']),
      AngelType_delete_view($angeltype)
  );
}
 
/**
 * Change an Angeltype.
 */
Function `angeltype_edit_controller` has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Method `angeltype_edit_controller` has 58 lines of code (exceeds 25 allowed). Consider refactoring.
function angeltype_edit_controller() {
  global $privileges, $user;
 
  $name = "";
  $restricted = false;
  $description = "";
  $requires_driver_license = false;
 
  if (isset($_REQUEST['angeltype_id'])) {
    $angeltype = AngelType($_REQUEST['angeltype_id']);
    if ($angeltype === false)
      engelsystem_error("Unable to load angeltype.");
    if ($angeltype == null)
      redirect(page_link_to('angeltypes'));
 
    $name = $angeltype['name'];
    $restricted = $angeltype['restricted'];
    $description = $angeltype['description'];
    $requires_driver_license = $angeltype['requires_driver_license'];
 
    if (! User_is_AngelType_coordinator($user, $angeltype))
      redirect(page_link_to('angeltypes'));
  } else {
    if (! in_array('admin_angel_types', $privileges))
      redirect(page_link_to('angeltypes'));
  }
 
  // In coordinator mode only allow to modify description
  $coordinator_mode = ! in_array('admin_angel_types', $privileges);
 
  if (isset($_REQUEST['submit'])) {
    $ok = true;
 
    if (! $coordinator_mode) {
      if (isset($_REQUEST['name'])) {
        list($valid, $name) = AngelType_validate_name($_REQUEST['name'], $angeltype);
        if (! $valid) {
          $ok = false;
          error(_("Please check the name. Maybe it already exists."));
        }
      }
 
      $restricted = isset($_REQUEST['restricted']);
      $requires_driver_license = isset($_REQUEST['requires_driver_license']);
    }
 
    if (isset($_REQUEST['description']))
      $description = strip_request_item_nl('description');
 
    if ($ok) {
      if (isset($angeltype)) {
        $result = AngelType_update($angeltype['id'], $name, $restricted, $description, $requires_driver_license);
        if ($result === false)
          engelsystem_error("Unable to update angeltype.");
        engelsystem_log("Updated angeltype: " . $name . ($restricted ? ", restricted" : "") . ($requires_driver_license ? ", requires driver license" : ""));
        $angeltype_id = $angeltype['id'];
      } else {
        $angeltype_id = AngelType_create($name, $restricted, $description, $requires_driver_license);
        if ($angeltype_id === false)
          engelsystem_error("Unable to create angeltype.");
        engelsystem_log("Created angeltype: " . $name . ($restricted ? ", restricted" : "") . ($requires_driver_license ? ", requires driver license" : ""));
      }
 
      success("Angel type saved.");
      redirect(angeltype_link($angeltype_id));
    }
  }
 
  return array(
      sprintf(_("Edit %s"), $name),
      AngelType_edit_view($name, $restricted, $description, $coordinator_mode, $requires_driver_license)
  );
}
 
/**
 * View details of a given angeltype.
 */
Function `angeltype_controller` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
function angeltype_controller() {
  global $privileges, $user;
 
  if (! in_array('angeltypes', $privileges))
    redirect('?');
 
  if (! isset($_REQUEST['angeltype_id']))
    redirect(page_link_to('angeltypes'));
 
  $angeltype = AngelType($_REQUEST['angeltype_id']);
  if ($angeltype === false)
    engelsystem_error("Unable to load angeltype.");
  if ($angeltype == null)
    redirect(page_link_to('angeltypes'));
 
  $user_angeltype = UserAngelType_by_User_and_AngelType($user, $angeltype);
  if ($user_angeltype === false)
    engelsystem_error("Unable to load user angeltype.");
 
  $user_driver_license = UserDriverLicense($user['UID']);
  if ($user_driver_license === false)
    engelsystem_error("Unable to load user driver license.");
 
  $members = Users_by_angeltype($angeltype);
  if ($members === false)
    engelsystem_error("Unable to load members.");
 
  return array(
      sprintf(_("Team %s"), $angeltype['name']),
      AngelType_view($angeltype, $members, $user_angeltype, in_array('admin_user_angeltypes', $privileges) || $user_angeltype['coordinator'], in_array('admin_angel_types', $privileges), $user_angeltype['coordinator'], $user_driver_license, $user)
  );
}
 
/**
 * View a list of all angeltypes.
 */
Method `angeltypes_list_controller` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Function `angeltypes_list_controller` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
function angeltypes_list_controller() {
  global $privileges, $user;
 
  if (! in_array('angeltypes', $privileges))
    redirect('?');
 
  $angeltypes = AngelTypes_with_user($user);
  if ($angeltypes === false)
    engelsystem_error("Unable to load angeltypes.");
 
  foreach ($angeltypes as &$angeltype) {
    $actions = array(
        button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("view"), "btn-xs")
    );
 
    if (in_array('admin_angel_types', $privileges)) {
      $actions[] = button(page_link_to('angeltypes') . '&action=edit&angeltype_id=' . $angeltype['id'], _("edit"), "btn-xs");
      $actions[] = button(page_link_to('angeltypes') . '&action=delete&angeltype_id=' . $angeltype['id'], _("delete"), "btn-xs");
    }
 
    $angeltype['membership'] = AngelType_render_membership($angeltype);
Similar blocks of code found in 2 locations. Consider refactoring.
    if ($angeltype['user_angeltype_id'] != null) {
      $actions[] = button(page_link_to('user_angeltypes') . '&action=delete&user_angeltype_id=' . $angeltype['user_angeltype_id'], _("leave"), "btn-xs");
    } else {
      $actions[] = button(page_link_to('user_angeltypes') . '&action=add&angeltype_id=' . $angeltype['id'], _("join"), "btn-xs");
    }
 
    $angeltype['restricted'] = $angeltype['restricted'] ? glyph('lock') : '';
    $angeltype['name'] = '<a href="' . page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'] . '">' . $angeltype['name'] . '</a>';
 
    $angeltype['actions'] = table_buttons($actions);
  }
 
  return array(
      angeltypes_title(),
      AngelTypes_list_view($angeltypes, in_array('admin_angel_types', $privileges))
  );
}
?>