Sign upLogin

fossasia/engelsystem

View on GitHub
Star
includes/controller/shifts_controller.php

Summary

Maintainability
A
3 hrs
Test Coverage

Showing 3 of 3 total issues

Function shift_controller has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

function shift_controller() {
  global $user, $privileges;
 
  if (! in_array('user_shifts', $privileges))
    redirect(page_link_to('?'));
Severity: Minor
Found in includes/controller/shifts_controller.php - About 1 hr to fix

Method shift_controller has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function shift_controller() {
  global $user, $privileges;
 
  if (! in_array('user_shifts', $privileges))
    redirect(page_link_to('?'));
Severity: Minor
Found in includes/controller/shifts_controller.php - About 1 hr to fix

    Function shifts_json_export_controller has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    function shifts_json_export_controller() {
      global $ical_shifts, $user;
     
      if (isset($_REQUEST['key']) && preg_match("/^[0-9a-f]{32}$/", $_REQUEST['key']))
        $key = $_REQUEST['key'];
    Severity: Minor
    Found in includes/controller/shifts_controller.php - About 45 mins to fix
    Category
    Status