Sign upLogin

fossasia/engelsystem

View on GitHub
Star
includes/controller/shifts_controller.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function shift_controller has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

function shift_controller() {
  global $user, $privileges;

  if (! in_array('user_shifts', $privileges))
    redirect(page_link_to('?'));
Severity: Minor
Found in includes/controller/shifts_controller.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method shift_controller has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function shift_controller() {
  global $user, $privileges;

  if (! in_array('user_shifts', $privileges))
    redirect(page_link_to('?'));
Severity: Minor
Found in includes/controller/shifts_controller.php - About 1 hr to fix

    Function shifts_json_export_controller has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    function shifts_json_export_controller() {
  global $ical_shifts, $user;

  if (isset($_REQUEST['key']) && preg_match("/^[0-9a-f]{32}$/", $_REQUEST['key']))
    $key = $_REQUEST['key'];
    Severity: Minor
    Found in includes/controller/shifts_controller.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status