Sign upLogin

fossasia/engelsystem

View on GitHub
Star
includes/controller/shifttypes_controller.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function shifttype_edit_controller has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

function shifttype_edit_controller() {
  $shifttype_id = null;
  $name = "";
  $angeltype_id = null;
  $description = "";
Severity: Minor
Found in includes/controller/shifttypes_controller.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method shifttype_edit_controller has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function shifttype_edit_controller() {
  $shifttype_id = null;
  $name = "";
  $angeltype_id = null;
  $description = "";
Severity: Major
Found in includes/controller/shifttypes_controller.php - About 2 hrs to fix

    Function shifttype_controller has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function shifttype_controller() {
  if (! isset($_REQUEST['shifttype_id']))
    redirect(page_link_to('shifttypes'));
  $shifttype = ShiftType($_REQUEST['shifttype_id']);
  if ($shifttype === false)
    Severity: Minor
    Found in includes/controller/shifttypes_controller.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function shifttype_delete_controller has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function shifttype_delete_controller() {
  if (! isset($_REQUEST['shifttype_id']))
    redirect(page_link_to('shifttypes'));
  $shifttype = ShiftType($_REQUEST['shifttype_id']);
  if ($shifttype === false)
    Severity: Minor
    Found in includes/controller/shifttypes_controller.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status