Sign upLogin

fossasia/engelsystem

View on GitHub
Star
includes/model/NeededAngelTypes_model.php

Summary

Maintainability
A
1 hr
Test Coverage

Showing 2 of 2 total issues

Method NeededAngelTypes_by_shift has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function NeededAngelTypes_by_shift($shiftId) {
  $needed_angeltypes_source = sql_select("
        SELECT `NeededAngelTypes`.*, `AngelTypes`.`name`, `AngelTypes`.`restricted`
        FROM `NeededAngelTypes`
        JOIN `AngelTypes` ON `AngelTypes`.`id` = `NeededAngelTypes`.`angel_type_id`
Severity: Minor
Found in includes/model/NeededAngelTypes_model.php - About 1 hr to fix

    Function NeededAngelTypes_by_shift has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    function NeededAngelTypes_by_shift($shiftId) {
      $needed_angeltypes_source = sql_select("
            SELECT `NeededAngelTypes`.*, `AngelTypes`.`name`, `AngelTypes`.`restricted`
            FROM `NeededAngelTypes`
            JOIN `AngelTypes` ON `AngelTypes`.`id` = `NeededAngelTypes`.`angel_type_id`
    Severity: Minor
    Found in includes/model/NeededAngelTypes_model.php - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status