fossasia/engelsystem

View on GitHub
includes/model/Room_model.php

Summary

Maintainability
A
3 hrs
Test Coverage

Showing 3 of 3 total issues

Method update_rooms has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function update_rooms($name, $from_pentabarf, $public, $number, $id, $event_id) {
Severity: Minor
Found in includes/model/Room_model.php - About 45 mins to fix

    Method Room_create has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function Room_create($name, $from_frab, $public, $number, $event_id) {
    Severity: Minor
    Found in includes/model/Room_model.php - About 35 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      function update_rooms($name, $from_pentabarf, $public, $number, $id, $event_id) {
      return sql_query("UPDATE `Room` SET `Name`='" . sql_escape($name) . "', `FromPentabarf`='" . sql_escape($from_pentabarf) . "', `show`='" . sql_escape($public) . "', `Number`='" . sql_escape($number) . "', `e_id`='" . sql_escape($event_id) . "' WHERE `RID`='" . sql_escape($id) . "' LIMIT 1");
      }
      Severity: Major
      Found in includes/model/Room_model.php and 2 other locations - About 2 hrs to fix
      includes/model/Settings_model.php on lines 12..20
      includes/model/Settings_model.php on lines 32..40

      There are no issues that match your filters.

      Category
      Status