fossasia/engelsystem

View on GitHub
includes/model/Settings_model.php

Summary

Maintainability
B
6 hrs
Test Coverage

Showing 4 of 4 total issues

Method Settings_create has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function Settings_create($event_name, $buildup_start_date, $event_start_date, $event_end_date, $teardown_end_date, $event_welcome_msg) {
Severity: Minor
Found in includes/model/Settings_model.php - About 45 mins to fix

    Method Settings_update has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function Settings_update($event_name, $buildup_start_date, $event_start_date, $event_end_date, $teardown_end_date, $event_welcome_msg) {
    Severity: Minor
    Found in includes/model/Settings_model.php - About 45 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      function Settings_create($event_name, $buildup_start_date, $event_start_date, $event_end_date, $teardown_end_date, $event_welcome_msg) {
      return sql_query("INSERT INTO `Settings` SET
      `event_name`='" . sql_escape($event_name) . "',
      `buildup_start_date`='" . sql_escape($buildup_start_date) . "',
      `event_start_date`='" . sql_escape($event_start_date) . "',
      Severity: Major
      Found in includes/model/Settings_model.php and 2 other locations - About 2 hrs to fix
      includes/model/Room_model.php on lines 84..86
      includes/model/Settings_model.php on lines 12..20

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      function Settings_update($event_name, $buildup_start_date, $event_start_date, $event_end_date, $teardown_end_date, $event_welcome_msg) {
      return sql_query("UPDATE `Settings` SET
      `event_name`='" . sql_escape($event_name) . "',
      `buildup_start_date`='" . sql_escape($buildup_start_date) . "',
      `event_start_date`='" . sql_escape($event_start_date) . "',
      Severity: Major
      Found in includes/model/Settings_model.php and 2 other locations - About 2 hrs to fix
      includes/model/Room_model.php on lines 84..86
      includes/model/Settings_model.php on lines 32..40

      There are no issues that match your filters.

      Category
      Status