fossasia/engelsystem

View on GitHub
includes/model/User_model.php

Summary

Maintainability
F
4 days
Test Coverage

Showing 11 of 11 total issues

File User_model.php has 410 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
 
/**
* User model
*/
Severity: Minor
Found in includes/model/User_model.php - About 5 hrs to fix

    Method insert_user has 25 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function insert_user($default_theme, $nick, $prename, $lastname, $age, $tel, $dect, $native_lang, $other_langs, $mobile, $mail, $email_shiftinfo, $jabber, $tshirt_size, $password_hash, $comment, $hometown, $twitter, $facebook, $github, $organization, $current_city, $organization_web, $timezone, $planned_arrival_date) {
    Severity: Major
    Found in includes/model/User_model.php - About 3 hrs to fix

      Method User_insert has 21 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function User_insert($nick, $prename, $lastname, $age, $tel, $dect, $mobile, $mail, $email_shiftinfo, $jabber, $tshirt_size, $password_hash, $comment, $hometown, $twitter, $facebook, $github, $organization, $organization_web, $timezone, $planned_arrival_date) {
      Severity: Major
      Found in includes/model/User_model.php - About 2 hrs to fix

        Method update_user has 17 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function update_user($eNick, $eName, $eVorname, $eTelefon, $eHandy, $eAlter, $eDECT, $eemail, $email_shiftinfo, $ejabber, $eSize, $eGekommen, $eAktiv, $force_active, $eTshirt, $Hometown, $id) {
        Severity: Major
        Found in includes/model/User_model.php - About 2 hrs to fix

          Method update_user_details has 16 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function update_user_details($nick, $prename, $lastname, $age, $tel, $dect, $mobile, $mail, $email_shiftinfo, $jabber, $tshirt_size, $hometown, $planned_arrival_date, $planned_departure_date, $timezone, $uid) {
          Severity: Major
          Found in includes/model/User_model.php - About 2 hrs to fix

            Method insert_user has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function insert_user($default_theme, $nick, $prename, $lastname, $age, $tel, $dect, $native_lang, $other_langs, $mobile, $mail, $email_shiftinfo, $jabber, $tshirt_size, $password_hash, $comment, $hometown, $twitter, $facebook, $github, $organization, $current_city, $organization_web, $timezone, $planned_arrival_date) {
            return sql_query("
            INSERT INTO `User` SET
            `color`='" . sql_escape($default_theme) . "',
            `Nick`='" . sql_escape($nick) . "',
            Severity: Minor
            Found in includes/model/User_model.php - About 1 hr to fix

              Method User_update has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function User_update($user) {
              return sql_query("UPDATE `User` SET
              `Nick`='" . sql_escape($user['Nick']) . "',
              `Name`='" . sql_escape($user['Name']) . "',
              `Vorname`='" . sql_escape($user['Vorname']) . "',
              Severity: Minor
              Found in includes/model/User_model.php - About 1 hr to fix

                Method User_insert has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function User_insert($nick, $prename, $lastname, $age, $tel, $dect, $mobile, $mail, $email_shiftinfo, $jabber, $tshirt_size, $password_hash, $comment, $hometown, $twitter, $facebook, $github, $organization, $organization_web, $timezone, $planned_arrival_date) {
                return sql_query("
                INSERT INTO `User` SET
                `Nick`='" . sql_escape($nick) . "',
                `Vorname`='" . sql_escape($prename) . "',
                Severity: Minor
                Found in includes/model/User_model.php - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  return sql_query("
                  UPDATE `User` SET
                  `Nick`='" . sql_escape($nick) . "',
                  `Vorname`='" . sql_escape($prename) . "',
                  `Name`='" . sql_escape($lastname) . "',
                  Severity: Major
                  Found in includes/model/User_model.php and 1 other location - About 7 hrs to fix
                  includes/model/User_model.php on lines 589..607

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  return sql_query("
                  INSERT INTO `User` SET
                  `color`='" . sql_escape($default_theme) . "',
                  `Nick`='" . sql_escape($nick) . "',
                  `Vorname`='" . sql_escape($prename) . "',
                  Severity: Major
                  Found in includes/model/User_model.php and 1 other location - About 7 hrs to fix
                  includes/model/User_model.php on lines 674..691

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  function update_user_sn($twitter, $facebook, $github, $uid) {
                  return sql_query("
                  UPDATE `User` SET
                  `twitter`='" . sql_escape($twitter) . "',
                  `facebook`='" . sql_escape($facebook) . "',
                  Severity: Minor
                  Found in includes/model/User_model.php and 1 other location - About 30 mins to fix
                  includes/model/ShiftTypes_model.php on lines 19..25

                  There are no issues that match your filters.

                  Category
                  Status