Sign upLogin

fossasia/open-event-orga-server

View on GitHub
Star
app/api/helpers/pentabarfxml.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function export has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    def export(event_id):
        """Takes an event id and returns the event in pentabarf XML format"""
        event = EventModel.query.get(event_id)
        diff = event.ends_at - event.starts_at
Severity: Minor
Found in app/api/helpers/pentabarfxml.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if session.ends_at is None or session.starts_at is None:
                            duration = ""
                        else:
                            duration = format_timedelta(
                                session.ends_at - session.starts_at
Severity: Major
Found in app/api/helpers/pentabarfxml.py - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                        for speaker in session.speakers:
                            person = Person(id=speaker.id, name=speaker.name)
                            session_event.add_person(person)
Severity: Major
Found in app/api/helpers/pentabarfxml.py - About 45 mins to fix

There are no issues that match your filters.

Category
Status