fossasia/open-event-orga-server

View on GitHub
app/api/helpers/scheduled_jobs.py

Summary

Maintainability
B
5 hrs
Test Coverage

File scheduled_jobs.py has 302 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import datetime
import logging

import pytz
from flask_celeryext import RequestContextTask
Severity: Minor
Found in app/api/helpers/scheduled_jobs.py - About 3 hrs to fix

Function send_after_event_mail has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def send_after_event_mail():
    current_time = datetime.datetime.now()
    events = (
        Event.query.filter_by(state='published', deleted_at=None)
        .filter(
Severity: Minor
Found in app/api/helpers/scheduled_jobs.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function send_event_invoice has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def send_event_invoice(
    self, event_id: int, send_notification: bool = True, force: bool = False
):
    this_month = this_month_date()
    # Check if this month's invoice has been generated
Severity: Minor
Found in app/api/helpers/scheduled_jobs.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status