Sign upLogin

fossasia/open-event-orga-server

View on GitHub
Star
app/views/healthcheck.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function check_migrations has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def check_migrations():
    """
    Checks whether database is up to date with migrations by performing a select query on each model
    :return:
    """
Severity: Minor
Found in app/views/healthcheck.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function health_check_celery has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def health_check_celery():
    """
    Check health status of celery and redis broker
    :return:
    """
Severity: Minor
Found in app/views/healthcheck.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return True, 'celery ok'
Severity: Major
Found in app/views/healthcheck.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return False, 'celery not ok'
Severity: Major
Found in app/views/healthcheck.py - About 30 mins to fix

There are no issues that match your filters.

Category
Status