Sign upLogin

fossasia/open-event-orga-server

View on GitHub
Star
migrations/versions/f63b9b9b645b_.py

Summary

Maintainability
C
7 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

def upgrade():
    # commands auto generated by Alembic - please adjust! #
    op.execute("ALTER TABLE email_notifications ALTER after_ticket_purchase TYPE boolean USING CASE after_ticket_purchase WHEN 1 THEN TRUE\
                ELSE FALSE END", execution_options=None)
    op.execute("ALTER TABLE email_notifications ALTER new_paper TYPE boolean USING CASE new_paper WHEN 1 THEN TRUE\
Severity: Major
Found in migrations/versions/f63b9b9b645b_.py and 2 other locations - About 3 hrs to fix
migrations/versions/43e8c59337ag_.py on lines 19..36
migrations/versions/f63b9b9b645b_.py on lines 34..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

def downgrade():
    # commands auto generated by Alembic - please adjust! #
    op.execute("ALTER TABLE image_sizes ALTER after_ticket_purchase TYPE integer USING CASE after_ticket_purchase WHEN TRUE THEN 1\
                ELSE 0 END", execution_options=None)
    op.execute("ALTER TABLE image_sizes ALTER new_paper TYPE integer USING CASE new_paper WHEN TRUE THEN 1\
Severity: Major
Found in migrations/versions/f63b9b9b645b_.py and 2 other locations - About 3 hrs to fix
migrations/versions/43e8c59337ag_.py on lines 19..36
migrations/versions/f63b9b9b645b_.py on lines 19..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status