Sign upLogin

fraction/fraction

View on GitHub
Star

Showing 16 of 16 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Routes.hot = {
  name: 'hot',
  controller: Routes.Controllers.news,
  path:     '/hot',
  waitOn: () => {
Severity: Major
Found in app/packages/fraction-routes/lib/routes/hot.next.js and 1 other location - About 6 hrs to fix
app/packages/fraction-routes/lib/routes/recent.next.js on lines 3..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 165.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Routes.recent = {
  name: 'recent',
  controller: Routes.Controllers.news,
  path:     '/recent',
  waitOn: () => {
Severity: Major
Found in app/packages/fraction-routes/lib/routes/recent.next.js and 1 other location - About 6 hrs to fix
app/packages/fraction-routes/lib/routes/hot.next.js on lines 3..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 165.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function vote has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  vote : (obj) => {
    if (typeof obj !== 'undefined') {
      new Meteor.Error(500, 'Must include object with content ID and vote');
    }
Severity: Minor
Found in app/packages/fraction-votes/lib/methods.next.js - About 1 hr to fix

    Function since has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      since: (before) => {
    var hn = Npm.require('hacker-news-api');

    var now = Math.floor(Date.now() / 1000);
    var listQuery = 'search?tags=story&numericFilters=created_at_i>';
    Severity: Minor
    Found in app/packages/fraction-hacker-news/lib/read.next.js - About 1 hr to fix

      Function countVotes has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var countVotes = () => {
  // find votes for object
  var deltaVotesQuery = {
    delta: {
      $exists: true
      Severity: Minor
      Found in app/packages/fraction-votes/lib/count.next.js - About 1 hr to fix

        Function tweetHot has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          var tweetHot = () => {
    var hot = Posts.find({}, {
      limit: 50,
      sort: {
        heat: -1
        Severity: Minor
        Found in app/packages/fraction-twitter/lib/tweetHot.next.js - About 1 hr to fix

          Function waitOn has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            waitOn: function () {
    var time = this.params.time.toLowerCase();

    // what type of time to subscribe to
    var actions = {
          Severity: Minor
          Found in app/packages/fraction-routes/lib/routes/top.next.js - About 1 hr to fix

            Function vote has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            var vote = function (event) {
  var target = $(event.target);
  var post = target.parent().parent().parent().parent().parent();

  // assume the best
            Severity: Minor
            Found in app/packages/fraction-votes/views/setVote.js - About 1 hr to fix

              Function onAfterAction has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                onAfterAction: function () {
    var time = this.params.time.toLowerCase();

    Routes.setNews('top');
    Session.set('sortTime', time);
              Severity: Minor
              Found in app/packages/fraction-routes/lib/routes/top.next.js - About 1 hr to fix

                Function vote has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                  vote : (obj) => {
    if (typeof obj !== 'undefined') {
      new Meteor.Error(500, 'Must include object with content ID and vote');
    }
                Severity: Minor
                Found in app/packages/fraction-votes/lib/methods.next.js - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function vote has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                var vote = function (event) {
  var target = $(event.target);
  var post = target.parent().parent().parent().parent().parent();

  // assume the best
                Severity: Minor
                Found in app/packages/fraction-votes/views/setVote.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    Session.set('posts', Posts.find({
      author: this.params.username
    }, {
      reactive: false
    }).fetch());
                Severity: Minor
                Found in app/packages/fraction-routes/lib/routes/user.next.js and 1 other location - About 40 mins to fix
                app/packages/fraction-routes/lib/routes/comments.next.js on lines 15..19

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    Session.set('comments', Posts.find({
      _id: this.params.id
    }, {
      reactive: false
    }).fetch());
                Severity: Minor
                Found in app/packages/fraction-routes/lib/routes/comments.next.js and 1 other location - About 40 mins to fix
                app/packages/fraction-routes/lib/routes/user.next.js on lines 16..20

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid too many return statements within this function.
                Open

                    return timeString(interval, 'min');
                Severity: Major
                Found in app/packages/fraction-utilities/lib/timeSince.next.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    return timeString(interval, 's');
                  Severity: Major
                  Found in app/packages/fraction-utilities/lib/timeSince.next.js - About 30 mins to fix

                    Function previousVote has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      previousVote: function () {
    var post = this._id;
    var voteQuery = {
      'user' : Meteor.userId(),
      'obj'  : post
                    Severity: Minor
                    Found in app/packages/fraction-posts/views/viewPost.next.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language