Showing 12 of 16 total issues
Function vote
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
vote : (obj) => {
if (typeof obj !== 'undefined') {
new Meteor.Error(500, 'Must include object with content ID and vote');
}
Function since
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
since: (before) => {
var hn = Npm.require('hacker-news-api');
var now = Math.floor(Date.now() / 1000);
var listQuery = 'search?tags=story&numericFilters=created_at_i>';
Function countVotes
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
var countVotes = () => {
// find votes for object
var deltaVotesQuery = {
delta: {
$exists: true
Function tweetHot
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
var tweetHot = () => {
var hot = Posts.find({}, {
limit: 50,
sort: {
heat: -1
Function waitOn
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
waitOn: function () {
var time = this.params.time.toLowerCase();
// what type of time to subscribe to
var actions = {
Function vote
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
var vote = function (event) {
var target = $(event.target);
var post = target.parent().parent().parent().parent().parent();
// assume the best
Function onAfterAction
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
onAfterAction: function () {
var time = this.params.time.toLowerCase();
Routes.setNews('top');
Session.set('sortTime', time);
Function vote
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
vote : (obj) => {
if (typeof obj !== 'undefined') {
new Meteor.Error(500, 'Must include object with content ID and vote');
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function vote
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
var vote = function (event) {
var target = $(event.target);
var post = target.parent().parent().parent().parent().parent();
// assume the best
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
return timeString(interval, 'min');
Avoid too many return
statements within this function. Open
return timeString(interval, 's');
Function previousVote
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
previousVote: function () {
var post = this._id;
var voteQuery = {
'user' : Meteor.userId(),
'obj' : post
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"