Sign upLogin

frapposelli/vagrant-vcloud

View on GitHub
Star
lib/vagrant-vcloud/config.rb

Summary

Maintainability
C
1 day
Test Coverage

Method validate has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

      def validate(machine)
        errors = _detected_errors

        # TODO: add blank?
        errors << I18n.t('vagrant_vcloud.config.hostname') if hostname.nil?
Severity: Minor
Found in lib/vagrant-vcloud/config.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def validate(machine)
        errors = _detected_errors

        # TODO: add blank?
        errors << I18n.t('vagrant_vcloud.config.hostname') if hostname.nil?
Severity: Major
Found in lib/vagrant-vcloud/config.rb - About 2 hrs to fix

Avoid deeply nested control flow statements.
Open

                if guest_customization_admin_password.nil? ||
                   guest_customization_admin_password.empty?
                  errors << I18n.t('vagrant_vcloud.gc.admin_password_gs')
                end
Severity: Major
Found in lib/vagrant-vcloud/config.rb - About 45 mins to fix

There are no issues that match your filters.

Category
Status