Sign upLogin

fratzinger/feathers-utils

View on GitHub
Star

Showing 126 of 126 total issues

Function mergeArrays has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  targetArr: T[] | undefined,
  sourceArr: T[] | undefined,
  handle: Handle,
  prependKey?: Path,
  actionOnEmptyIntersect?: ActionOnEmptyIntersect,
Severity: Minor
Found in src/utils/mergeQuery/mergeArrays.ts - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        it("returns source", function () {
      const arr = mergeArrays([1], [2], "source");

      expect(arr).toStrictEqual([2]);
    });
    Severity: Minor
    Found in src/utils/mergeQuery/mergeArrays.ts and 1 other location - About 35 mins to fix
    src/utils/mergeQuery/mergeArrays.ts on lines 56..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        it("returns target", function () {
      const arr = mergeArrays([1], [2], "target");

      expect(arr).toStrictEqual([1]);
    });
    Severity: Minor
    Found in src/utils/mergeQuery/mergeArrays.ts and 1 other location - About 35 mins to fix
    src/utils/mergeQuery/mergeArrays.ts on lines 70..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function defineParamsFromClient has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    export function defineParamsFromClient(keyToHide: string) {
  return function paramsFromClient(
    ...whitelist: string[]
  ): (context: HookContext) => HookContext {
    return (context: HookContext): HookContext => {
    Severity: Minor
    Found in src/hooks/from-client-for-server/paramsFromClient.ts - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function shouldSkip has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    export const shouldSkip = <H extends HookContext = HookContext>(
  hookName: string,
  context: H,
  options?: ShouldSkipOptions,
): boolean => {
    Severity: Minor
    Found in src/utils/shouldSkip.ts - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function setResultEmpty has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    export const setResultEmpty = <H extends HookContext = HookContext>(
  context: H,
) => {
  if (context.result) {
    return context;
    Severity: Minor
    Found in src/utils/setResultEmpty.ts - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function pushSet has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    export const pushSet = (
  obj: Record<string, unknown>,
  path: string | Path,
  val: unknown,
  options?: PushSetOptions,
    Severity: Minor
    Found in src/utils/pushSet.ts - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            const newVals = sourceVal.filter(
          (x: unknown) => !targetVal.some((y: unknown) => _isEqual(x, y)),
        );
    Severity: Minor
    Found in src/utils/mergeQuery/utils.ts and 1 other location - About 35 mins to fix
    src/utils/mergeQuery/utils.ts on lines 174..176

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            const newVals = sourceVal.filter(
          (x: unknown) => !targetVal.some((y: unknown) => _isEqual(x, y)),
        );
    Severity: Minor
    Found in src/utils/mergeQuery/utils.ts and 1 other location - About 35 mins to fix
    src/utils/mergeQuery/utils.ts on lines 213..215

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

          return;
    Severity: Major
    Found in src/utils/mergeQuery/utils.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return;
      Severity: Major
      Found in src/utils/mergeQuery/utils.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return;
        Severity: Major
        Found in src/utils/mergeQuery/utils.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return;
          Severity: Major
          Found in src/utils/mergeQuery/utils.ts - About 30 mins to fix

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

                      const context = {
            method,
            type,
            params: {
              user: {
            Severity: Major
            Found in src/hooks/setData.ts and 7 other locations - About 30 mins to fix
            src/hooks/setData.ts on lines 320..328
            src/hooks/setData.ts on lines 352..360
            src/hooks/setData.ts on lines 384..392
            src/hooks/setData.ts on lines 418..426
            src/hooks/setData.ts on lines 454..462
            src/hooks/setData.ts on lines 488..496
            src/hooks/setData.ts on lines 560..568

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                return;
            Severity: Major
            Found in src/utils/mergeQuery/utils.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return;
              Severity: Major
              Found in src/utils/mergeQuery/utils.ts - About 30 mins to fix

                Similar blocks of code found in 8 locations. Consider refactoring.
                Open

                          const context = {
            method,
            type,
            params: {
              user: {
                Severity: Major
                Found in src/hooks/setData.ts and 7 other locations - About 30 mins to fix
                src/hooks/setData.ts on lines 320..328
                src/hooks/setData.ts on lines 352..360
                src/hooks/setData.ts on lines 384..392
                src/hooks/setData.ts on lines 418..426
                src/hooks/setData.ts on lines 488..496
                src/hooks/setData.ts on lines 520..528
                src/hooks/setData.ts on lines 560..568

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid too many return statements within this function.
                Open

                    return [...new Set(arr)];
                Severity: Major
                Found in src/utils/mergeQuery/mergeArrays.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    return undefined;
                  Severity: Major
                  Found in src/utils/mergeQuery/mergeArrays.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return;
                    Severity: Major
                    Found in src/utils/mergeQuery/utils.ts - About 30 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language