fratzinger/feathers-utils

View on GitHub
src/hooks/setData.ts

Summary

Maintainability
D
2 days
Test Coverage
A
99%

File setData.ts has 520 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import _get from "lodash/get.js";
import _set from "lodash/set.js";
import _has from "lodash/has.js";

import { Forbidden } from "@feathersjs/errors";
Severity: Major
Found in src/hooks/setData.ts - About 1 day to fix

    Function setData has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function setData<H extends HookContext = HookContext>(
      from: PropertyPath,
      to: PropertyPath,
      _options?: HookSetDataOptions,
    ) {
    Severity: Minor
    Found in src/hooks/setData.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                result[dataOrResult].forEach((item, i) => {
                  assert.strictEqual(
                    item.userId,
                    i,
                    `${type}/${method}': ${dataOrResult} has 'userId:${i}`,
      Severity: Major
      Found in src/hooks/setData.ts and 1 other location - About 1 hr to fix
      src/hooks/setData.ts on lines 576..582

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                result[dataOrResult].forEach((item, i) => {
                  assert.strictEqual(
                    item.userId,
                    i,
                    `${type}/${method}': ${dataOrResult} has 'userId:${i}`,
      Severity: Major
      Found in src/hooks/setData.ts and 1 other location - About 1 hr to fix
      src/hooks/setData.ts on lines 434..440

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                result[dataOrResult].forEach((item) => {
                  assert.strictEqual(
                    item.userId,
                    1,
                    `${type}/${method}': ${dataOrResult} has 'userId:1'`,
      Severity: Major
      Found in src/hooks/setData.ts and 3 other locations - About 1 hr to fix
      src/hooks/setData.ts on lines 164..170
      src/hooks/setData.ts on lines 196..202
      src/hooks/setData.ts on lines 470..476

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              result[dataOrResult].forEach((item) => {
                assert.strictEqual(
                  item.userId,
                  1,
                  `'${type}/${method}': ${dataOrResult} has 'userId:1'`,
      Severity: Major
      Found in src/hooks/setData.ts and 3 other locations - About 1 hr to fix
      src/hooks/setData.ts on lines 164..170
      src/hooks/setData.ts on lines 400..406
      src/hooks/setData.ts on lines 470..476

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              result[dataOrResult].forEach((item) => {
                assert.strictEqual(
                  item.userId,
                  1,
                  `'${type}/${method}': ${dataOrResult} has 'userId:1'`,
      Severity: Major
      Found in src/hooks/setData.ts and 3 other locations - About 1 hr to fix
      src/hooks/setData.ts on lines 196..202
      src/hooks/setData.ts on lines 400..406
      src/hooks/setData.ts on lines 470..476

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                result[dataOrResult].forEach((item) => {
                  assert.strictEqual(
                    item.userId,
                    1,
                    `'${type}/${method}': ${dataOrResult} has 'userId:1'`,
      Severity: Major
      Found in src/hooks/setData.ts and 3 other locations - About 1 hr to fix
      src/hooks/setData.ts on lines 164..170
      src/hooks/setData.ts on lines 196..202
      src/hooks/setData.ts on lines 400..406

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

                const context = {
                  method,
                  type,
                  params: {
                    user: {
      Severity: Major
      Found in src/hooks/setData.ts and 7 other locations - About 30 mins to fix
      src/hooks/setData.ts on lines 320..328
      src/hooks/setData.ts on lines 352..360
      src/hooks/setData.ts on lines 384..392
      src/hooks/setData.ts on lines 418..426
      src/hooks/setData.ts on lines 454..462
      src/hooks/setData.ts on lines 488..496
      src/hooks/setData.ts on lines 560..568

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

                const context = {
                  method,
                  type,
                  params: {
                    user: {
      Severity: Major
      Found in src/hooks/setData.ts and 7 other locations - About 30 mins to fix
      src/hooks/setData.ts on lines 320..328
      src/hooks/setData.ts on lines 352..360
      src/hooks/setData.ts on lines 384..392
      src/hooks/setData.ts on lines 418..426
      src/hooks/setData.ts on lines 488..496
      src/hooks/setData.ts on lines 520..528
      src/hooks/setData.ts on lines 560..568

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

                const context = {
                  method,
                  type,
                  params: {
                    user: {
      Severity: Major
      Found in src/hooks/setData.ts and 7 other locations - About 30 mins to fix
      src/hooks/setData.ts on lines 320..328
      src/hooks/setData.ts on lines 352..360
      src/hooks/setData.ts on lines 384..392
      src/hooks/setData.ts on lines 418..426
      src/hooks/setData.ts on lines 454..462
      src/hooks/setData.ts on lines 488..496
      src/hooks/setData.ts on lines 520..528

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

                const context = {
                  method,
                  type,
                  params: {
                    user: {
      Severity: Major
      Found in src/hooks/setData.ts and 7 other locations - About 30 mins to fix
      src/hooks/setData.ts on lines 320..328
      src/hooks/setData.ts on lines 384..392
      src/hooks/setData.ts on lines 418..426
      src/hooks/setData.ts on lines 454..462
      src/hooks/setData.ts on lines 488..496
      src/hooks/setData.ts on lines 520..528
      src/hooks/setData.ts on lines 560..568

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

                const context = {
                  method,
                  type,
                  params: {
                    user: {
      Severity: Major
      Found in src/hooks/setData.ts and 7 other locations - About 30 mins to fix
      src/hooks/setData.ts on lines 320..328
      src/hooks/setData.ts on lines 352..360
      src/hooks/setData.ts on lines 418..426
      src/hooks/setData.ts on lines 454..462
      src/hooks/setData.ts on lines 488..496
      src/hooks/setData.ts on lines 520..528
      src/hooks/setData.ts on lines 560..568

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

                const context = {
                  method,
                  type,
                  params: {
                    user: {
      Severity: Major
      Found in src/hooks/setData.ts and 7 other locations - About 30 mins to fix
      src/hooks/setData.ts on lines 320..328
      src/hooks/setData.ts on lines 352..360
      src/hooks/setData.ts on lines 384..392
      src/hooks/setData.ts on lines 418..426
      src/hooks/setData.ts on lines 454..462
      src/hooks/setData.ts on lines 520..528
      src/hooks/setData.ts on lines 560..568

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

                const context = {
                  method,
                  type,
                  params: {
                    user: {
      Severity: Major
      Found in src/hooks/setData.ts and 7 other locations - About 30 mins to fix
      src/hooks/setData.ts on lines 320..328
      src/hooks/setData.ts on lines 352..360
      src/hooks/setData.ts on lines 384..392
      src/hooks/setData.ts on lines 454..462
      src/hooks/setData.ts on lines 488..496
      src/hooks/setData.ts on lines 520..528
      src/hooks/setData.ts on lines 560..568

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

                const context = {
                  method,
                  type,
                  params: {
                    user: {
      Severity: Major
      Found in src/hooks/setData.ts and 7 other locations - About 30 mins to fix
      src/hooks/setData.ts on lines 352..360
      src/hooks/setData.ts on lines 384..392
      src/hooks/setData.ts on lines 418..426
      src/hooks/setData.ts on lines 454..462
      src/hooks/setData.ts on lines 488..496
      src/hooks/setData.ts on lines 520..528
      src/hooks/setData.ts on lines 560..568

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status