Sign upLogin

frc-frecon/frecon

View on GitHub
Star

Showing 31 of 31 total issues

Method initialize has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
Open

        def initialize(args)
            if args.is_a?(String)
                # Match `args' against the regular expression, described below.
                #
                # This regular expression matches all values where the first group of
Severity: Minor
Found in lib/frecon/match_number.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for initialize is too high. [26/6]
Open

        def initialize(args)
            if args.is_a?(String)
                # Match `args' against the regular expression, described below.
                #
                # This regular expression matches all values where the first group of
Severity: Minor
Found in lib/frecon/match_number.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method has too many lines. [47/30]
Open

        def initialize(args)
            if args.is_a?(String)
                # Match `args' against the regular expression, described below.
                #
                # This regular expression matches all values where the first group of
Severity: Minor
Found in lib/frecon/match_number.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method initialize has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

        def initialize(*args)
            if args.length == 1
                # Match `string' against the regular expression, described below.
                #
                # This regular expression matches all values for `string' where
Severity: Minor
Found in lib/frecon/position.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method read has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        def read(data, context = {})
            # `data` will be a string, so we need to convert it from JSON.
            data = JSON.parse(data)

            if context[:type] == :single && data.empty?
Severity: Minor
Found in lib/frecon/scraper.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for initialize is too high. [12/6]
Open

        def initialize(*args)
            if args.length == 1
                # Match `string' against the regular expression, described below.
                #
                # This regular expression matches all values for `string' where
Severity: Minor
Found in lib/frecon/position.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method has too many lines. [35/30]
Open

        def self.resource_routes(base, name, controller)
            base.post "/#{name}" do
                begin
                    controller.create request, params
                rescue RequestError => e
Severity: Minor
Found in lib/frecon/routes.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method create has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

        def self.create(request, params, post_data = nil)
            post_data ||= process_json_request request

            if post_data.is_an? Array
                results = post_data.map do |post_data_item|
Severity: Minor
Found in lib/frecon/controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for read is too high. [9/6]
Open

        def read(data, context = {})
            # `data` will be a string, so we need to convert it from JSON.
            data = JSON.parse(data)

            if context[:type] == :single && data.empty?
Severity: Minor
Found in lib/frecon/scraper.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Cyclomatic complexity for setup! is too high. [8/6]
Open

        def self.setup!
            Mongoid.load!(File.join(File.dirname(__FILE__), 'mongoid.yml'), FReCon::ENVIRONMENT.variable)

            level = case (configured_level = FReCon::ENVIRONMENT.console['level'])
                    when /^d/i
Severity: Minor
Found in lib/frecon/database.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method initialize has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def initialize(args)
            if args.is_a?(String)
                # Match `args' against the regular expression, described below.
                #
                # This regular expression matches all values where the first group of
Severity: Minor
Found in lib/frecon/match_number.rb - About 1 hr to fix

    Cyclomatic complexity for to_s is too high. [7/6]
    Open

            def to_s
            type_string = case @type
                          when :practice
                              'p'
                          when :qualification
    Severity: Minor
    Found in lib/frecon/match_number.rb by rubocop

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Cyclomatic complexity for read_configurations is too high. [7/6]
    Open

            def read_configurations
            # Read the configurations
            default = default_configuration
            system = system_configuration
            user = user_configuration
    Severity: Minor
    Found in lib/frecon/base/environment.rb by rubocop

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Cyclomatic complexity for get is too high. [7/6]
    Open

            def get(model = nil, query = {})
            # Turns something like 'team' into Team.
            model = ('FReCon::' + model.capitalize).constantize if model.is_a?(String)

            # The route name for the model branch.
    Severity: Minor
    Found in lib/frecon/scraper.rb by rubocop

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Method resource_routes has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def self.resource_routes(base, name, controller)
            base.post "/#{name}" do
                begin
                    controller.create request, params
                rescue RequestError => e
    Severity: Minor
    Found in lib/frecon/routes.rb - About 1 hr to fix

      Method included has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def self.included(base)
            resource_routes base, 'teams', TeamsController
            resource_routes base, 'competitions', CompetitionsController
            resource_routes base, 'matches', MatchesController
            resource_routes base, 'records', RecordsController
      Severity: Minor
      Found in lib/frecon/routes.rb - About 1 hr to fix

        Method resource_routes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

                def self.resource_routes(base, name, controller)
            base.post "/#{name}" do
                begin
                    controller.create request, params
                rescue RequestError => e
        Severity: Minor
        Found in lib/frecon/routes.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method create has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def self.create(request, params, post_data = nil)
            post_data ||= process_json_request request

            if post_data.is_an? Array
                results = post_data.map do |post_data_item|
        Severity: Minor
        Found in lib/frecon/controller.rb - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  def self.mongoize(object)
            case object
            when Position
                object.mongoize
            when String
          Severity: Minor
          Found in lib/frecon/position.rb and 1 other location - About 45 mins to fix
          lib/frecon/position.rb on lines 82..93

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 41.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  def self.evolve(object)
            case object
            when Position
                object.mongoize
            when String
          Severity: Minor
          Found in lib/frecon/position.rb and 1 other location - About 45 mins to fix
          lib/frecon/position.rb on lines 58..69

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 41.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language