Sign upLogin

freakimkaefig/Music-XML-Analyzer

View on GitHub
Star

Showing 286 of 286 total issues

Function initNoteDistribution has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    initNoteDistribution = function(data) {
        $('#bar_noteDistribution').empty();
        var containerWidth = $('#bar_noteDistribution').width() - 30;
        var margin ={ top:20, right:30, bottom:50, left: 40 },
            width = containerWidth - margin.left - margin.right,
Severity: Major
Found in public/js/views/DashboardView.js - About 2 hrs to fix

    Function renderVexFlowNotePreview has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        renderVexFlowNotePreview = function() {
        // delete canvas
        context.clearRect(0, 0, canvas.width, canvas.height);
        stave.setContext(context).draw();
    Severity: Major
    Found in public/js/views/NotationView.js - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php

use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Migrations\Migration;
      Severity: Major
      Found in app/database/migrations/2015_01_28_153653_files_results_relation.php and 1 other location - About 2 hrs to fix
      app/database/migrations/2015_01_28_153221_users_files_relation.php on lines 1..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php

use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Migrations\Migration;
      Severity: Major
      Found in app/database/migrations/2015_01_28_153221_users_files_relation.php and 1 other location - About 2 hrs to fix
      app/database/migrations/2015_01_28_153653_files_results_relation.php on lines 1..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function search has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          public function search($pattern) {

        $p = $pattern[0]->notes;
        self::$patternArray = array();
        self::$results = array();
      Severity: Minor
      Found in app/controllers/RhythmController.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function search has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          public function search($pattern) {

        $p = $pattern[0]->notes;
        self::$patternArray = array();
        self::$results = array();
      Severity: Minor
      Found in app/controllers/MelodyController.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File DashboardModel.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /** @constructor */
MusicXMLAnalyzer.DashboardModel = function(){

    var that = {},
      Severity: Minor
      Found in public/js/models/DashboardModel.js - About 2 hrs to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    for (var typeCounter = 0; typeCounter < resultsArr[i].value.note_types.length; typeCounter++) {
                mergedArr.note_types[typeCounter].value += resultsArr[i].value.note_types[typeCounter].value;
            }
        Severity: Major
        Found in public/js/models/DashboardModel.js and 3 other locations - About 2 hrs to fix
        public/js/models/DashboardModel.js on lines 334..336
        public/js/models/DashboardModel.js on lines 339..341
        public/js/models/DashboardModel.js on lines 361..363

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 82.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    for (var intervalCounter = 0; intervalCounter < resultsArr[i].value.intervals.length; intervalCounter++) {
                mergedArr.intervals[intervalCounter].value += resultsArr[i].value.intervals[intervalCounter].value;
            }
        Severity: Major
        Found in public/js/models/DashboardModel.js and 3 other locations - About 2 hrs to fix
        public/js/models/DashboardModel.js on lines 339..341
        public/js/models/DashboardModel.js on lines 361..363
        public/js/models/DashboardModel.js on lines 366..368

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 82.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    for (var noteCounter = 0; noteCounter < resultsArr[i].value.note_distribution.length; noteCounter++) {
                mergedArr.note_distribution[noteCounter].value += resultsArr[i].value.note_distribution[noteCounter].value;
            }
        Severity: Major
        Found in public/js/models/DashboardModel.js and 3 other locations - About 2 hrs to fix
        public/js/models/DashboardModel.js on lines 334..336
        public/js/models/DashboardModel.js on lines 339..341
        public/js/models/DashboardModel.js on lines 366..368

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 82.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    for (var keyCounter = 0; keyCounter < resultsArr[i].value.key.length; keyCounter++) {
                mergedArr.key[keyCounter].value += resultsArr[i].value.key[keyCounter].value;
            }
        Severity: Major
        Found in public/js/models/DashboardModel.js and 3 other locations - About 2 hrs to fix
        public/js/models/DashboardModel.js on lines 334..336
        public/js/models/DashboardModel.js on lines 361..363
        public/js/models/DashboardModel.js on lines 366..368

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 82.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function getVexflowDuration has 58 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            getVexflowDuration = function(duration, type) {
        switch (duration) {
            case "whole":
                switch (type) {
                    case 0: return "w"; break;        // 0 is normal note
        Severity: Major
        Found in public/js/views/ResultView.js - About 2 hrs to fix

          Function getVexflowDuration has 58 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              getVexflowDuration = function(duration, type) {
        switch (duration) {
            case "whole":
                switch (type) {
                    case 0: return "w"; break;        // 0 is normal note
          Severity: Major
          Found in public/js/views/ScoreView.js - About 2 hrs to fix

            Method _determineClef has 58 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function _determineClef($xml){
        $clefs = $xml->xpath("//clef");

        $clefsArray = array(
            (object)array("label" => "soprano clef", "value" => 0 ),
            Severity: Major
            Found in app/controllers/SearchController.php - About 2 hrs to fix

              Function _determineClef has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function _determineClef($xml){
        $clefs = $xml->xpath("//clef");

        $clefsArray = array(
            (object)array("label" => "soprano clef", "value" => 0 ),
              Severity: Minor
              Found in app/controllers/SearchController.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if(currentResultNotes.measures[i].notes[j].type == 'rest'){
                        var rest = currentResultNotes.measures[i].notes[j];
                        var restDuration = getDuration(currentResultNotes.measures[i].notes[j].duration);
                        notesToBePlayed.push({'note': 0, 'noteDuration': restDuration});
              Severity: Major
              Found in public/js/controllers/ResultController.js and 1 other location - About 2 hrs to fix
              public/js/controllers/ScoreController.js on lines 119..138

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 80.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              if(scoreData.measures[i].notes[j].type === 'rest'){
                    var rest = scoreData.measures[i].notes[j];
                    var restDuration = getDuration(scoreData.measures[i].notes[j].duration);
                    notesToBePlayed.push({'note': 0, 'noteDuration': restDuration});
                }
              Severity: Major
              Found in public/js/controllers/ScoreController.js and 1 other location - About 2 hrs to fix
              public/js/controllers/ResultController.js on lines 159..186

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 80.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  getDurationIn64th = function(duration) {
        switch (duration) {
            case "whole":
                return 64; break;
            case "half":
              Severity: Major
              Found in public/js/views/ScoreView.js and 1 other location - About 2 hrs to fix
              public/js/views/ResultView.js on lines 671..690

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 79.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  getDurationIn64th = function(duration) {
        switch (duration) {
            case "whole":
                return 64; break;
            case "half":
              Severity: Major
              Found in public/js/views/ResultView.js and 1 other location - About 2 hrs to fix
              public/js/views/ScoreView.js on lines 310..329

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 79.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if($fifths != null && $mode === "major"){
            switch($fifths) {
                case "0": return "C major"; break;
                case "1": return "G major"; break;
                case "2": return "D major"; break;
              Severity: Major
              Found in app/controllers/ResultController.php and 1 other location - About 2 hrs to fix
              app/controllers/ResultController.php on lines 506..524

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 125.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language