Sign upLogin

freepn/fpnd

View on GitHub
Star
node_tools/network_funcs.py

Summary

Maintainability
C
1 day
Test Coverage

File network_funcs.py has 363 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# coding: utf-8

"""Network helper functions."""
from __future__ import print_function
Severity: Minor
Found in node_tools/network_funcs.py - About 4 hrs to fix

    Function do_net_check has a Cognitive Complexity of 24 (exceeds 18 allowed). Consider refactoring.
    Open

    def do_net_check(path=None):
    """
    Try and get the geoip location using fpn route.
    :param path: path to script dir
    """
    Severity: Minor
    Found in node_tools/network_funcs.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function do_net_cmd has a Cognitive Complexity of 22 (exceeds 18 allowed). Consider refactoring.
    Open

    def do_net_cmd(cmd):
    """
    Actual net command runner (see above).
    """
    import os
    Severity: Minor
    Found in node_tools/network_funcs.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function drain_msg_queue has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def drain_msg_queue(reg_q, pub_q=None, tmp_q=None, addr=None, method='handle_node'):
    Severity: Minor
    Found in node_tools/network_funcs.py - About 35 mins to fix

      Function get_net_cmds has a Cognitive Complexity of 19 (exceeds 18 allowed). Consider refactoring.
      Open

      def get_net_cmds(bin_dir, iface=None, state=False):
    import os

    res = None
    if not os.path.isdir(bin_dir):
      Severity: Minor
      Found in node_tools/network_funcs.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function echo_client has a Cognitive Complexity of 19 (exceeds 18 allowed). Consider refactoring.
      Open

      def echo_client(fpn_id, addr, send_cfg=False):
    import json
    from node_tools import state_data as st
    from node_tools.msg_queues import make_version_msg
    from node_tools.node_funcs import do_shutdown
      Severity: Minor
      Found in node_tools/network_funcs.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if 'setup' in tail:
            if 'fpn0' in tail:
                st.fpn0Data['state'] = 'UP'
            else:
                st.fpn1Data['state'] = 'UP'
      Severity: Major
      Found in node_tools/network_funcs.py and 1 other location - About 1 hr to fix
      node_tools/network_funcs.py on lines 381..385

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if 'down' in tail:
            if 'fpn0' in tail:
                st.fpn0Data['state'] = 'DOWN'
            else:
                st.fpn1Data['state'] = 'DOWN'
      Severity: Major
      Found in node_tools/network_funcs.py and 1 other location - About 1 hr to fix
      node_tools/network_funcs.py on lines 376..380

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status