Sign upLogin

freepn/fpnd

View on GitHub
Star
node_tools/trie_funcs.py

Summary

Maintainability
C
1 day
Test Coverage

File trie_funcs.py has 332 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# coding: utf-8

"""trie-specific helper functions."""

import logging
Severity: Minor
Found in node_tools/trie_funcs.py - About 4 hrs to fix

    Function get_neighbor_ids has a Cognitive Complexity of 30 (exceeds 18 allowed). Consider refactoring.
    Open

    def get_neighbor_ids(trie, node_id):
    """
    Given the node ID, get the payloads from the net trie and return
    the attached network and neighbor node IDs.
    :param trie: net data trie
    Severity: Minor
    Found in node_tools/trie_funcs.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function load_id_trie has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def load_id_trie(net_trie, id_trie, nw_id, node_id, needs=[], nw=False):
    Severity: Minor
    Found in node_tools/trie_funcs.py - About 45 mins to fix

      Function cleanup_state_tries has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def cleanup_state_tries(net_trie, id_trie, nw_id, node_id, mbr_only=False):
      Severity: Minor
      Found in node_tools/trie_funcs.py - About 35 mins to fix

        Function update_id_trie has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def update_id_trie(trie, nw_id, node_id, needs=[], nw=False):
        Severity: Minor
        Found in node_tools/trie_funcs.py - About 35 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              for node_id in [x for x in list(id_trie) if len(x) == 10 and not is_exit_node(x)]:
          Severity: Major
          Found in node_tools/trie_funcs.py and 1 other location - About 1 hr to fix
          node_tools/trie_funcs.py on lines 162..162

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 38.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              for node in [x for x in list(id_trie) if len(x) == 10 and not is_exit_node(x)]:
          Severity: Major
          Found in node_tools/trie_funcs.py and 1 other location - About 1 hr to fix
          node_tools/trie_funcs.py on lines 134..134

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 38.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          for node in trie.suffixes(src_net)[1:]:
                    if node_id != node:
                        src_node = node
          Severity: Minor
          Found in node_tools/trie_funcs.py and 1 other location - About 35 mins to fix
          node_tools/trie_funcs.py on lines 274..276

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          for node in trie.suffixes(exit_net)[1:]:
                    if node_id != node:
                        exit_node = node
          Severity: Minor
          Found in node_tools/trie_funcs.py and 1 other location - About 35 mins to fix
          node_tools/trie_funcs.py on lines 269..271

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status