Sign upLogin

freqtrade/freqtrade

View on GitHub
Star
freqtrade/freqai/prediction_models/ReinforcementLearner.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function calculate_reward has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

        def calculate_reward(self, action: int) -> float:
            """
            An example reward function. This is the one function that users will likely
            wish to inject their own creativity into.
Severity: Minor
Found in freqtrade/freqai/prediction_models/ReinforcementLearner.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def fit(self, data_dictionary: Dict[str, Any], dk: FreqaiDataKitchen, **kwargs):
        """
        User customizable fit method
        :param data_dictionary: dict = common data dictionary containing all train/test
            features/labels/weights.
Severity: Minor
Found in freqtrade/freqai/prediction_models/ReinforcementLearner.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                return -1 * trade_duration / max_trade_duration
Severity: Major
Found in freqtrade/freqai/prediction_models/ReinforcementLearner.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return float(pnl * factor)
    Severity: Major
    Found in freqtrade/freqai/prediction_models/ReinforcementLearner.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return 0.
      Severity: Major
      Found in freqtrade/freqai/prediction_models/ReinforcementLearner.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return float(pnl * factor)
        Severity: Major
        Found in freqtrade/freqai/prediction_models/ReinforcementLearner.py - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status