Sign upLogin

freqtrade/freqtrade

View on GitHub
Star
freqtrade/persistence/key_value_store.py

Summary

Maintainability
A
1 hr
Test Coverage

Avoid too many return statements within this function.
Open

            return kv.int_value
Severity: Major
Found in freqtrade/persistence/key_value_store.py - About 30 mins to fix

    Function get_value has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_value(key: KeyStoreKeys) -> Optional[ValueTypes]:
        """
        Get the value for the given key.
        :param key: Key to get the value for
        """
    Severity: Minor
    Found in freqtrade/persistence/key_value_store.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function store_value has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def store_value(key: KeyStoreKeys, value: ValueTypes) -> None:
        """
        Store the given value for the given key.
        :param key: Key to store the value for - can be used in get-value to retrieve the key
        :param value: Value to store - can be str, datetime, float or int
    Severity: Minor
    Found in freqtrade/persistence/key_value_store.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status