Sign upLogin

freqtrade/freqtrade

View on GitHub
Star
freqtrade/persistence/pairlock_middleware.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function unlock_reason has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def unlock_reason(reason: str, now: Optional[datetime] = None) -> None:
        """
        Release all locks for this reason.
        :param reason: Which reason to unlock
        :param now: Datetime object (generated via datetime.now(timezone.utc)).
Severity: Minor
Found in freqtrade/persistence/pairlock_middleware.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

        if PairLocks.use_db:
            return PairLock.query_pair_locks(pair, now, side).all()
        else:
            locks = [
                lock
Severity: Major
Found in freqtrade/persistence/pairlock_middleware.py - About 40 mins to fix

    Function lock_pair has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def lock_pair(
    Severity: Minor
    Found in freqtrade/persistence/pairlock_middleware.py - About 35 mins to fix

      Function get_pair_locks has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_pair_locks(
        pair: Optional[str], now: Optional[datetime] = None, side: str = "*"
    ) -> Sequence[PairLock]:
        """
        Get all currently active locks for this pair
      Severity: Minor
      Found in freqtrade/persistence/pairlock_middleware.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status